r111351 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111350‎ | r111351 | r111352 >
Date:07:36, 13 February 2012
Author:wikinaut
Status:reverted (Comments)
Tags:gerritmigration 
Comment:
follow-up r111350 . check if optional parameter isset and is_numeric, otherwise limit to the built-in default (30000)
Modified paths:
  • /trunk/extensions/RSS/RSS.php (modified) (history)
  • /trunk/extensions/RSS/RSSParser.php (modified) (history)

Diff [purge]

Index: trunk/extensions/RSS/RSSParser.php
@@ -80,7 +80,7 @@
8181 case ( isset( $args['item-max-length'] ) ):
8282 $this->ItemMaxLength = $args['item-max-length'];
8383 break;
84 - case ( isset( $wgRSSItemMaxLength ) ):
 84+ case ( isset( $wgRSSItemMaxLength ) && is_numeric( $wgRSSItemMaxLength ) ):
8585 $this->ItemMaxLength = $wgRSSItemMaxLength;
8686 break;
8787 }
Index: trunk/extensions/RSS/RSS.php
@@ -71,4 +71,5 @@
7272
7373 // limit the number of characters in the item description
7474 // or set to false for unlimited length.
 75+// $wgRSSItemMaxLength = false;
7576 // $wgRSSItemMaxLength = 100;

Follow-up revisions

RevisionCommit summaryAuthorDate
r111816follow-up r111350 r111351 . switch replaced by if elseif construct.wikinaut07:35, 18 February 2012
r114390Revert r111347, r111348, r111350, r111351, r111515, r111816, r112243, r112251......catrope18:40, 21 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111350fix for bug30377 : add a new parameter to limit the number of characters when...wikinaut07:23, 13 February 2012

Comments

#Comment by Wikinaut (talk | contribs)   07:39, 13 February 2012

in the commit comment change "built-in default (30000)" to "otherwise limit to the built-in default (200)". See r111350 .

Status & tagging log