r112710 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112709‎ | r112710 | r112711 >
Date:20:02, 29 February 2012
Author:brion
Status:ok
Tags:
Comment:
* (bug 34768) Set width and height for search-ltr.png (and search-rtl.png) in Vector skin

<img> in <button> didn't have width or height set.
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -430,11 +430,11 @@
431431 <?php if ( $wgVectorUseSimpleSearch && $this->getSkin()->getUser()->getOption( 'vector-simplesearch' ) ): ?>
432432 <div id="simpleSearch">
433433 <?php if ( $this->data['rtl'] ): ?>
434 - <?php echo $this->makeSearchButton( 'image', array( 'id' => 'searchButton', 'src' => $this->getSkin()->getSkinStylePath( 'images/search-rtl.png' ) ) ); ?>
 434+ <?php echo $this->makeSearchButton( 'image', array( 'id' => 'searchButton', 'src' => $this->getSkin()->getSkinStylePath( 'images/search-rtl.png' ), 'width' => '12', 'height' => '13' ) ); ?>
435435 <?php endif; ?>
436436 <?php echo $this->makeSearchInput( array( 'id' => 'searchInput', 'type' => 'text' ) ); ?>
437437 <?php if ( !$this->data['rtl'] ): ?>
438 - <?php echo $this->makeSearchButton( 'image', array( 'id' => 'searchButton', 'src' => $this->getSkin()->getSkinStylePath( 'images/search-ltr.png' ) ) ); ?>
 438+ <?php echo $this->makeSearchButton( 'image', array( 'id' => 'searchButton', 'src' => $this->getSkin()->getSkinStylePath( 'images/search-ltr.png' ), 'width' => '12', 'height' => '13' ) ); ?>
439439 <?php endif; ?>
440440 <?php else: ?>
441441 <div>

Status & tagging log