r111515 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r111514‎ | r111515 | r111516 >
Date:00:11, 15 February 2012
Author:wikinaut
Status:reverted
Tags:gerritmigration 
Comment:
removed a wrong comment regarding PHP 5.3 function date_create_from_format, which is not suited to auto-detect a time string in any formats - only strtotime() can do it.
Modified paths:
  • /trunk/extensions/RSS/RSSParser.php (modified) (history)

Diff [purge]

Index: trunk/extensions/RSS/RSSParser.php
@@ -316,7 +316,6 @@
317317 $txt = $this->sanitizeUrl( $item[ $info ] );
318318 break;
319319 case 'date':
320 - // PHP > 5.3.0 users can better use date_create_from_format method to reformat a date string
321320 $tempTimezone = date_default_timezone_get();
322321 date_default_timezone_set( 'UTC' );
323322 $txt = date( $this->date, strtotime( $this->escapeTemplateParameter( $item[ $info ] ) ) );

Follow-up revisions

RevisionCommit summaryAuthorDate
r114390Revert r111347, r111348, r111350, r111351, r111515, r111816, r112243, r112251......catrope18:40, 21 March 2012

Status & tagging log