r112251 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112250‎ | r112251 | r112252 >
Date:22:24, 23 February 2012
Author:wikinaut
Status:reverted
Tags:gerritmigration 
Comment:
increased wgRSSFetchTimeout default from 5 to 15 seconds - many sites are too slow.
Modified paths:
  • /trunk/extensions/RSS/RSS.php (modified) (history)
  • /trunk/extensions/RSS/RSSHooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/RSS/RSSHooks.php
@@ -34,7 +34,7 @@
3535
3636 switch ( true ) {
3737
38 - # disallow because there is no whitelist or emtpy whitelist
 38+ # disallow because there is no whitelist or empty whitelist
3939 case ( !isset( $wgRSSUrlWhitelist )
4040 || !is_array( $wgRSSUrlWhitelist )
4141 || ( count( $wgRSSUrlWhitelist ) === 0 ) ):
Index: trunk/extensions/RSS/RSS.php
@@ -52,7 +52,7 @@
5353 $wgRSSCacheCompare = false;
5454
5555 // 5 second timeout
56 -$wgRSSFetchTimeout = 5;
 56+$wgRSSFetchTimeout = 15;
5757
5858 // Ignore the RSS tag in all but the namespaces listed here.
5959 // null (the default) means the <rss> tag can be used anywhere.

Follow-up revisions

RevisionCommit summaryAuthorDate
r114390Revert r111347, r111348, r111350, r111351, r111515, r111816, r112243, r112251......catrope18:40, 21 March 2012

Status & tagging log