r112563 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112562‎ | r112563 | r112564 >
Date:02:04, 28 February 2012
Author:aaron
Status:ok (Comments)
Tags:
Comment:
Force the target user ID to be the correct foreign ID on the relevant local wikis for crosswiki suppress blocks.
Modified paths:
  • /trunk/phase3/includes/Block.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Block.php
@@ -71,6 +71,9 @@
7272 }
7373
7474 $this->setTarget( $address );
 75+ if ( $this->target instanceof User && $user ) {
 76+ $this->target->setId( $user ); // needed for foreign users
 77+ }
7578 if ( $by ) { // local user
7679 $this->setBlocker( User::newFromID( $by ) );
7780 } else { // foreign user

Follow-up revisions

RevisionCommit summaryAuthorDate
r112564MFT r112563, r112533, r112534aaron02:09, 28 February 2012
r112566r112563: Removed random bogus user IDs passed into to Block constructor in testsaaron02:32, 28 February 2012
r113157MFT r112563, r112566, r112838, r112872, r112873, r112988, r113001, r113024, r...reedy17:36, 6 March 2012
r114672(bug 35011) Use the correct user name & ID for crosswiki blocks....aaron23:22, 2 April 2012

Comments

#Comment by Aaron Schulz (talk | contribs)   02:04, 28 February 2012

This is for bug 34539.

Status & tagging log