r112566 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112565‎ | r112566 | r112567 >
Date:02:32, 28 February 2012
Author:aaron
Status:ok
Tags:
Comment:
r112563: Removed random bogus user IDs passed into to Block constructor in tests
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/BlockTest.php (modified) (history)
  • /trunk/phase3/tests/phpunit/includes/TitlePermissionTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/BlockTest.php
@@ -35,7 +35,7 @@
3636 $oldBlock->delete();
3737 }
3838
39 - $this->block = new Block( 'UTBlockee', 1, 0,
 39+ $this->block = new Block( 'UTBlockee', $user->getID(), 0,
4040 'Parce que', 0, false, time() + 100500
4141 );
4242 $this->madeAt = wfTimestamp( TS_MW );
Index: trunk/phase3/tests/phpunit/includes/TitlePermissionTest.php
@@ -629,7 +629,7 @@
630630 $prev = time();
631631 $now = time() + 120;
632632 $this->user->mBlockedby = $this->user->getId();
633 - $this->user->mBlock = new Block( '127.0.8.1', $this->user->getId(), $this->user->getId(),
 633+ $this->user->mBlock = new Block( '127.0.8.1', 0, $this->user->getId(),
634634 'no reason given', $prev + 3600, 1, 0 );
635635 $this->user->mBlock->mTimestamp = 0;
636636 $this->assertEquals( array( array( 'autoblockedtext',
@@ -646,7 +646,7 @@
647647 global $wgLocalTZoffset;
648648 $wgLocalTZoffset = -60;
649649 $this->user->mBlockedby = $this->user->getName();
650 - $this->user->mBlock = new Block( '127.0.8.1', 2, 1, 'no reason given', $now, 0, 10 );
 650+ $this->user->mBlock = new Block( '127.0.8.1', 0, 1, 'no reason given', $now, 0, 10 );
651651 $this->assertEquals( array( array( 'blockedtext',
652652 '[[User:Useruser|Useruser]]', 'no reason given', '127.0.0.1',
653653 'Useruser', null, '23:00, 31 December 1969', '127.0.8.1',

Follow-up revisions

RevisionCommit summaryAuthorDate
r112568MFT r112566aaron02:40, 28 February 2012
r113157MFT r112563, r112566, r112838, r112872, r112873, r112988, r113001, r113024, r...reedy17:36, 6 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112563Force the target user ID to be the correct foreign ID on the relevant local w...aaron02:04, 28 February 2012

Status & tagging log