r112564 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112563‎ | r112564 | r112565 >
Date:02:09, 28 February 2012
Author:aaron
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.19wmf1 (modified) (history)
  • /branches/wmf/1.19wmf1/includes (modified) (history)
  • /branches/wmf/1.19wmf1/includes/Block.php (modified) (history)
  • /branches/wmf/1.19wmf1/includes/resourceloader (modified) (history)
  • /branches/wmf/1.19wmf1/includes/resourceloader/ResourceLoaderContext.php (modified) (history)
  • /branches/wmf/1.19wmf1/resources/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/includes/resourceloader/ResourceLoaderContext.php
@@ -63,7 +63,9 @@
6464 $this->only = $request->getVal( 'only' );
6565 $this->version = $request->getVal( 'version' );
6666
67 - if ( !$this->skin ) {
 67+ $skinnames = Skin::getSkinNames();
 68+ // If no skin is specified, or we don't recognize the skin, use the default skin
 69+ if ( !$this->skin || !isset( $skinnames[$this->skin] ) ) {
6870 $this->skin = $wgDefaultSkin;
6971 }
7072 }
Property changes on: branches/wmf/1.19wmf1/includes/resourceloader
___________________________________________________________________
Modified: svn:mergeinfo
7173 Merged /trunk/phase3/includes/resourceloader:r112534
Index: branches/wmf/1.19wmf1/includes/Block.php
@@ -71,6 +71,9 @@
7272 }
7373
7474 $this->setTarget( $address );
 75+ if ( $this->target instanceof User && $user ) {
 76+ $this->target->setId( $user ); // needed for foreign users
 77+ }
7578 if ( $by ) { // local user
7679 $this->setBlocker( User::newFromID( $by ) );
7780 } else { // foreign user
Property changes on: branches/wmf/1.19wmf1/includes
___________________________________________________________________
Modified: svn:mergeinfo
7881 Merged /trunk/phase3/includes:r112534,112563
Index: branches/wmf/1.19wmf1/resources/mediawiki/mediawiki.js
@@ -1183,7 +1183,8 @@
11841184 * "text/javascript"; if no type is provided, text/javascript is assumed.
11851185 * @param async {Boolean} (optional) If true, load modules asynchronously
11861186 * even if document ready has not yet occurred. If false (default),
1187 - * block before document ready and load async after
 1187+ * block before document ready and load async after. If not set, true will
 1188+ * be assumed if loading a URL, and false will be assumed otherwise.
11881189 */
11891190 load: function ( modules, type, async ) {
11901191 var filtered, m;
@@ -1196,6 +1197,10 @@
11971198 if ( typeof modules === 'string' ) {
11981199 // Support adding arbitrary external scripts
11991200 if ( /^(https?:)?\/\//.test( modules ) ) {
 1201+ if ( async === undefined ) {
 1202+ // Assume async for bug 34542
 1203+ async = true;
 1204+ }
12001205 if ( type === 'text/css' ) {
12011206 $( 'head' ).append( $( '<link>', {
12021207 rel: 'stylesheet',
Property changes on: branches/wmf/1.19wmf1
___________________________________________________________________
Modified: svn:mergeinfo
12031208 Merged /trunk/phase3:r112533-112534,112563

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r112533(bug 34542) Calling mw.loader.load('http://someurlhere') sometimes calls docu...catrope22:33, 27 February 2012
r112534In ResourceLoaderContext, normalize invalid skin names to $wgDefaultSkin . Th...catrope22:41, 27 February 2012
r112563Force the target user ID to be the correct foreign ID on the relevant local w...aaron02:04, 28 February 2012

Status & tagging log