r112872 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112871‎ | r112872 | r112873 >
Date:04:00, 2 March 2012
Author:tstarling
Status:ok
Tags:
Comment:
Fix for r86304: if MessageCache::parse() is called twice, once with $interface=true and then with $interface=false, actually use $interface=false the second time instead of using the cached value from the previous call. Same for $language. This is the reason why edittools was affected by bug 34832.
Modified paths:
  • /trunk/phase3/includes/cache/MessageCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/cache/MessageCache.php
@@ -834,14 +834,9 @@
835835
836836 $parser = $this->getParser();
837837 $popts = $this->getParserOptions();
 838+ $popts->setInterfaceMessage( $interface );
 839+ $popts->setTargetLanguage( $language );
838840
839 - if ( $interface ) {
840 - $popts->setInterfaceMessage( true );
841 - }
842 - if ( $language !== null ) {
843 - $popts->setTargetLanguage( $language );
844 - }
845 -
846841 wfProfileIn( __METHOD__ );
847842 if ( !$title || !$title instanceof Title ) {
848843 global $wgTitle;

Follow-up revisions

RevisionCommit summaryAuthorDate
r112873(bug 34832) Parse recentchangestext with the interface option off, since it c...tstarling04:52, 2 March 2012
r113024Transitional patch for bug 34832: introduce a CI-style option to allow deploy...tstarling12:14, 5 March 2012
r113119MFT r112872, r112873, r113001, r113024: language converter fixeststarling02:09, 6 March 2012
r113157MFT r112563, r112566, r112838, r112872, r112873, r112988, r113001, r113024, r...reedy17:36, 6 March 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86304* (bug 28532) wfMsgExt() and wfMsgWikiHtml() use $wgOut->parse()...reedy12:43, 18 April 2011

Status & tagging log