r112562 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r112561‎ | r112562 | r112563 >
Date:01:57, 28 February 2012
Author:saper
Status:ok (Comments)
Tags:
Comment:
Restore "checkuser-log-return" ("Return to CheckUser main form") link to the CU log

This was accidentally removed in r100506
Modified paths:
  • /trunk/extensions/CheckUser/SpecialCheckUserLog.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CheckUser/SpecialCheckUserLog.php
——@@ -60,6 +60,10 @@
6161 }
6262 }
6363 }
 64+
 65+ $out->addHTML( $this->getSkin()->makeKnownLinkObj(
 66+ Title::makeTitle( NS_SPECIAL, 'CheckUser' ),
 67+ wfMsgHtml( 'checkuser-log-return' ) ) );
6468
6569 $searchTypes = array( 'initiator', 'target' );
6670 $select = "<select name=\"cuSearchType\" style='margin-top:.2em;'>\n";

Follow-up revisions

RevisionCommit summaryAuthorDate
r1125701.19wmf1: MFT r111983, r112384, r112451, r112561, r112562, r112567catrope02:55, 28 February 2012
r112586Followup-to: r100506: Improve linking between Special:CheckUser and Special:C...saper11:23, 28 February 2012
r112648MFT r112074, r112153, r112295, r112517, r112562, r112628reedy21:43, 28 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100506Moved CheckUser log stuff into a separate special pagejohnduhart17:44, 22 October 2011

Comments

#Comment by Nikerabbit (talk | contribs)   07:47, 28 February 2012

Lots of deprecated code in here.

Should be something along the lines of 

Linker::link( SpecialPageFactory::getTitleFor( 'CheckUser' ), $this->msg( 'checkuser-log-return' ) );
#Comment by Saper (talk | contribs)   11:26, 28 February 2012

Sees like it is SpecialPage::getTitleFor, improved in r112586.

Is there any way to improve 

    $wgOut->addWikiText( wfMsg( 'checkuser-summary' ) .
		"\n\n[[" . $this->getCheckUserLogTitle()->getPrefixedText() .

ugliness using Linker class?

#Comment by Nikerabbit (talk | contribs)   12:00, 28 February 2012

Can you provide full context? Why do you want to use linker there?

#Comment by Saper (talk | contribs)   12:22, 28 February 2012

It's in CheckUser_body.php, line 108. I guess there must be a nice way to produce this link.

Status & tagging log