r112517 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112516‎ | r112517 | r112518 >
Date:21:15, 27 February 2012
Author:brion
Status:ok
Tags:
Comment:
Revert r110506: undo change to phrasing on Special:UploadWizard's most important button

The big button label was changed from 'Select a media file to donate' to 'Drop media file to donate here' to make it "clear that it's possible to drag and drop multiple files".
Unfortunately this is probably premature; the drag-n-drop isn't very slickly integrated yet and for instance has no visual indication of whether you're dropping in the right stop. If you get it wrong -- very easy -- then you replace the entire page with just your image in the browser window (bug 34667).
Switching it back to the original form.
Modified paths:
  • /trunk/extensions/UploadWizard/UploadWizard.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/UploadWizard.i18n.php
@@ -38,7 +38,7 @@
3939 'mwe-upwiz-help-desk' => 'Help Desk',
4040 'mwe-upwiz-help-desk-url' => 'Help Desk',
4141 'mwe-upwiz-add-file-n' => 'Add another file',
42 - 'mwe-upwiz-add-file-0-free' => 'Drop media file to donate here',
 42+ 'mwe-upwiz-add-file-0-free' => 'Select a media file to donate',
4343 'mwe-upwiz-transport-started' => 'Starting...',
4444 'mwe-upwiz-uploading' => 'Uploading...',
4545 'mwe-upwiz-transported' => 'Finished uploading...',

Sign-offs

UserFlagDate
Nikerabbitinspected07:07, 28 February 2012

Follow-up revisions

RevisionCommit summaryAuthorDate
r112531MFT r112517reedy22:24, 27 February 2012
r112648MFT r112074, r112153, r112295, r112517, r112562, r112628reedy21:43, 28 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r110506Changing the message on the big button so it will be clear that it's possible...amire8018:09, 1 February 2012

Status & tagging log