r110506 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r110505‎ | r110506 | r110507 >
Date:18:09, 1 February 2012
Author:amire80
Status:reverted (Comments)
Tags:
Comment:
Changing the message on the big button so it will be clear that it's possible to drag and drop multiple files.
Modified paths:
  • /trunk/extensions/UploadWizard/UploadWizard.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/UploadWizard.i18n.php
——@@ -38,7 +38,7 @@
3939 'mwe-upwiz-help-desk' => 'Help Desk',
4040 'mwe-upwiz-help-desk-url' => 'Help Desk',
4141 'mwe-upwiz-add-file-n' => 'Add another file',
42 - 'mwe-upwiz-add-file-0-free' => 'Select a media file to donate',
 42+ 'mwe-upwiz-add-file-0-free' => 'Drop media file to donate here',
4343 'mwe-upwiz-transport-started' => 'Starting...',
4444 'mwe-upwiz-uploading' => 'Uploading...',
4545 'mwe-upwiz-transported' => 'Finished uploading...',

Follow-up revisions

RevisionCommit summaryAuthorDate
r112517Revert r110506: undo change to phrasing on Special:UploadWizard's most import...brion21:15, 27 February 2012

Comments

#Comment by Mormegil (talk | contribs)   09:44, 10 February 2012

I don’t think this is a good idea. Drag&drop is a fairly advanced functionality. While it is fine to support D&D, it is not necessary to advertise it in a way which can confuse newbie users (the primary target of the wizard). Cf. Gmail which supports attaching files by D&D, but does not say “Drop an attachment”, but keeps the old “Attach a file”, with a large “Drop files here to add them as attachments” displayed when somebody actually drags them over the window.

#Comment by Brion VIBBER (talk | contribs)   21:13, 27 February 2012

Agreed; bug 34667 gives an example of how drag-n-drop goes wrong here if you don't drop in exactly the right place.

We should switch this back until the drag-n-drop experience is much nicer, and even then maybe label it differently.

Status & tagging log