r112074 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r112073‎ | r112074 | r112075 >
Date:01:53, 22 February 2012
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Falling through to the floor is going to end in tears

Ping r104236
Modified paths:
  • /trunk/extensions/CentralAuth/specials/SpecialMergeAccount.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/specials/SpecialMergeAccount.php
——@@ -57,16 +57,22 @@
5858 switch( $this->mMergeAction ) {
5959 case "dryrun":
6060 $this->doDryRunMerge();
 61+ break;
6162 case "initial":
6263 $this->doInitialMerge();
 64+ break;
6365 case "cleanup":
6466 $this->doCleanupMerge();
 67+ break;
6568 case "attach":
6669 $this->doAttachMerge();
 70+ break;
6771 case "remove":
68 - $this->doUnattach();
 72+ $this->doUnattach(); // FIXME: Method is undefined
 73+ break;
6974 default:
70 - $this->invalidAction();
 75+ $this->invalidAction(); // FIXME: Method is undefined
 76+ break;
7177 }
7278 return;
7379 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r112075MFT r112074reedy01:56, 22 February 2012
r112648MFT r112074, r112153, r112295, r112517, r112562, r112628reedy21:43, 28 February 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104236Update comments, some braces...reedy12:53, 25 November 2011

Comments

#Comment by Nikerabbit (talk | contribs)   08:12, 22 February 2012

Classical.

Status & tagging log