r112153 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r112152‎ | r112153 | r112154 >
Date:21:55, 22 February 2012
Author:brion
Status:ok
Tags:
Comment:
* (bug 34598) Double search dropdowns sometimes appearing

Forces mwsuggest to load before vector simple search, so we can guarantee that we disable it. (If it were loaded second and ready already called, then it could load simplesearch first and fail to disable mwsuggest.)
Modified paths:
  • /trunk/extensions/Vector/Vector.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Vector/Vector.php
——@@ -125,6 +125,7 @@
126126 'jquery.suggestions',
127127 'jquery.autoEllipsis',
128128 'jquery.placeholder',
 129+ 'mediawiki.legacy.mwsuggest', // to ensure we disable it in proper order
129130 ),
130131 ),
131132 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r112164MFT r111604, r111796, r112153, r112160reedy23:31, 22 February 2012
r112648MFT r112074, r112153, r112295, r112517, r112562, r112628reedy21:43, 28 February 2012

Status & tagging log