r112164 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r112163‎ | r112164 | r112165 >
Date:23:31, 22 February 2012
Author:reedy
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.19wmf1/extensions (modified) (history)
  • /branches/wmf/1.19wmf1/extensions/UploadWizard (modified) (history)
  • /branches/wmf/1.19wmf1/extensions/UploadWizard/resources/mw.fileApi.js (modified) (history)
  • /branches/wmf/1.19wmf1/extensions/Vector (modified) (history)
  • /branches/wmf/1.19wmf1/extensions/Vector/Vector.php (modified) (history)
  • /branches/wmf/1.19wmf1/extensions/WikiEditor/WikiEditor.hooks.php (modified) (history)
  • /branches/wmf/1.19wmf1/extensions/WikiEditor/WikiEditor.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.19wmf1/extensions/WikiEditor/WikiEditor.php
@@ -62,6 +62,7 @@
6363 $wgHooks['GetPreferences'][] = 'WikiEditorHooks::getPreferences';
6464 $wgHooks['ResourceLoaderGetConfigVars'][] = 'WikiEditorHooks::resourceLoaderGetConfigVars';
6565 $wgHooks['MakeGlobalVariablesScript'][] = 'WikiEditorHooks::makeGlobalVariablesScript';
 66+$wgHooks['EditPageBeforeEditToolbar'][] = 'WikiEditorHooks::EditPageBeforeEditToolbar';
6667
6768 $wikiEditorTpl = array(
6869 'localBasePath' => dirname( __FILE__ ) . '/modules',
Index: branches/wmf/1.19wmf1/extensions/WikiEditor/WikiEditor.hooks.php
@@ -214,6 +214,21 @@
215215 }
216216
217217 /**
 218+ * EditPageBeforeEditToolbar hook
 219+ *
 220+ * Disable the old toolbar if the new one is enabled
 221+ *
 222+ * @param $toolbar html
 223+ * @return bool
 224+ */
 225+ public static function EditPageBeforeEditToolbar( &$toolbar ) {
 226+ if ( self::isEnabled( 'toolbar' ) ) {
 227+ $toolbar = '';
 228+ }
 229+ return true;
 230+ }
 231+
 232+ /**
218233 * GetPreferences hook
219234 *
220235 * Adds WikiEditor-releated items to the preferences
Index: branches/wmf/1.19wmf1/extensions/Vector/Vector.php
@@ -125,6 +125,7 @@
126126 'jquery.suggestions',
127127 'jquery.autoEllipsis',
128128 'jquery.placeholder',
 129+ 'mediawiki.legacy.mwsuggest', // to ensure we disable it in proper order
129130 ),
130131 ),
131132 );
Property changes on: branches/wmf/1.19wmf1/extensions/Vector
___________________________________________________________________
Modified: svn:mergeinfo
132133 Merged /trunk/extensions/Vector:r112153,112160
Index: branches/wmf/1.19wmf1/extensions/UploadWizard/resources/mw.fileApi.js
@@ -32,9 +32,9 @@
3333 * @todo is there a way to check this instead of hardcoding browsers and version?
3434 */
3535 isSliceAvailable: function() {
36 - return mw.fileApi.isAvailable() &&
37 - ( ($j.browser.mozilla && $j.browser.version >= '5.0') ||
38 - ($j.browser.webkit && $j.browser.version >= '534.28') );
 36+ return mw.fileApi.isAvailable() &&
 37+ ( ($j.browser.mozilla && parseFloat($j.browser.version) >= 5.0) ||
 38+ ($j.browser.webkit && parseFloat($j.browser.version) >= 534.28) );
3939 }
4040
4141
Property changes on: branches/wmf/1.19wmf1/extensions/UploadWizard
___________________________________________________________________
Modified: svn:mergeinfo
4242 Merged /trunk/extensions/UploadWizard:r111604,111796,112153,112160
Property changes on: branches/wmf/1.19wmf1/extensions
___________________________________________________________________
Modified: svn:mergeinfo
4343 Merged /trunk/extensions:r111604,111796,112153,112160

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r111604Fixes Bug 34333 - multi file selection with FF10 fails...mah00:52, 16 February 2012
r111796fix for bug34431 - Disable the old toolbar if the new toolbar is enabledbsitu22:13, 17 February 2012
r112153* (bug 34598) Double search dropdowns sometimes appearing...brion21:55, 22 February 2012
r112160Followup r111796, always return truereedy23:07, 22 February 2012

Status & tagging log