r104073 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104072‎ | r104073 | r104074 >
Date:19:40, 23 November 2011
Author:jpostlethwaite
Status:ok
Tags:fundraising 
Comment:
Fixing messages for Donate-error page. The message now uses parameters. See r104001.
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_common/interface.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_common/interface.i18n.php
@@ -192,11 +192,7 @@
193193 'donate_interface-error-msg-captcha-please' => "For your credit card security, please type the characters you see above.",
194194 'donate_interface-error-msg-cookies' => 'Please enable cookies in your browser.',
195195 'donate_interface-error-msg-genaricrequired' => 'This field is required',
196 - 'donate_interface-donate-error-please' => 'Please',
197 - 'donate_interface-donate-error-try-a-different-card' => 'try a different card',
198 - 'donate_interface-donate-error-or-one-of-our' => 'or one of our',
199 - 'donate_interface-donate-error-other-ways-to-give' => 'other ways to give',
200 - 'donate_interface-donate-error-or-contact-us-at' => 'or contact us at mailto:donate@wikimedia.org.',
 196+ 'donate_interface-donate-error-try-a-different-card' => 'Please [$1 try a different card] or one of our [$2 other ways to give] or contact us at $3',
201197 'donate_interface-donate-error-thank-you-for-your-support' => 'Thank you for your support!',
202198 'php-response-declined' => 'Your transaction could not be accepted.',
203199 'donate_interface-thankyou' => 'Thank you for your donation!',
@@ -638,17 +634,14 @@
639635 'donate_interface-error-msg-captcha-please' => 'Message given the user if he/she has to fill out a [[w:en:CAPTCHA|CAPTCHA]] before the donation is fulfilled.',
640636 'donate_interface-error-msg-cookies' => "Error message if the user's browser has cookies disabled",
641637 'donate_interface-error-msg-genaricrequired' => 'Message displayed to a user if a field is required but not filled out when they try to submit',
642 - 'donate_interface-donate-error-please' => 'All of the messages prefixed with "donate_interface-donate-error-" are part of a message on /index.php/Donate-error.
 638+ 'donate_interface-donate-error-try-a-different-card' => 'This message will be displayed in the the article /index.php/Donate-error.
 639+
 640+It will take three parameters:
643641
644 -The full message:
645 -
646 -Please try a different card or one of our other ways to give or contact us at mailto:donate@wikimedia.org.
647 -
648 -Thank you for your support!',
649 - 'donate_interface-donate-error-try-a-different-card' => 'This is a link so a user can try a different card.',
650 - 'donate_interface-donate-error-or-one-of-our' => 'Text to complete the sentence with: donate_interface-donate-error-try-a-different-card and donate_interface-donate-error-other-ways-to-give.',
651 - 'donate_interface-donate-error-other-ways-to-give' => 'This is a link to other ways to give.',
652 - 'donate_interface-donate-error-or-contact-us-at' => 'Contact us',
 642+1. A link back to the form to try another credit card.
 643+2. A link to other payment methods.
 644+3. An email address link such as: mailto:someone@example.com
 645+ ',
653646 'donate_interface-donate-error-thank-you-for-your-support' => 'Thank you for your support!',
654647 'php-response-declined' => 'Error message if the translaction was declined.',
655648 'donate_interface-thankyou' => 'A thank you for donating.',

Sign-offs

UserFlagDate
Jsobyinspected19:42, 23 November 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r104096MFT r104001, r104062, r104073khorn22:29, 23 November 2011
r106245MFT r102664, r102689, r102736, r102807, r102812, r102824, r102872, r102922, r...awjrichards21:26, 14 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104001Adding translations for Donate-error.jpostlethwaite01:54, 23 November 2011

Status & tagging log