r102807 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102806‎ | r102807 | r102808 >
Date:18:59, 11 November 2011
Author:jpostlethwaite
Status:resolved (Comments)
Tags:fundraising 
Comment:
Checking in translations for BPAY
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_common/interface.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_common/interface.i18n.php
@@ -338,6 +338,12 @@
339339 'donate_interface-bt-information' => 'Bank transfer information',
340340 'donate_interface-bt-finished' => 'Finished',
341341
 342+ // Online bank transfer (obt)
 343+ 'donate_interface-obt-biller_id' => 'Biller code',
 344+ 'donate_interface-obt-customer_payment_reference' => 'Reference #',
 345+ 'donate_interface-obt-information' => 'Online bank transfer information',
 346+ 'donate_interface-online_bank_transfer_message' => 'Telephone & Internet Banking - BPAY©',
 347+
342348 // Real time bank transfer (rtbt)
343349 'donate_interface-rtbt-issuer_id' => 'Choose a Bank',
344350 'donate_interface-rtbt-issuer_id-longlist' => 'Other banks',
@@ -726,6 +732,10 @@
727733 'donate_interface-bt-special_id' => 'Bank transfer: Special ID',
728734 'donate_interface-bt-information' => 'Bank transfer: Bank transfer information',
729735 'donate_interface-bt-finished' => 'Bank transfer: Finished - this is a link or a button to take the user to the Thank you page for their donation.',
 736+ 'donate_interface-obt-biller_id' => 'BPAY (Australian Online Bank Transfer) - The label for biller code',
 737+ 'donate_interface-obt-customer_payment_reference' => 'BPAY (Australian Online Bank Transfer) - The customer reference number label',
 738+ 'donate_interface-obt-information' => 'BPAY (Australian Online Bank Transfer) - The second level header on the web page',
 739+ 'donate_interface-online_bank_transfer_message' => 'BPAY (Australian Online Bank Transfer) - The message displayed about the BPAY transaction.',
730740 'donate_interface-rtbt-issuer_id' => 'Real time bank transfer: Select a Bank used to pick which bank the donor wishes to use for their donation',
731741 'donate_interface-dd-account_name' => 'Direct Debit: Account Name - Name of person who owns the Bank Account',
732742 'donate_interface-dd-account_number' => 'Direct Debit: Account Number - Bank account number to be used for the Direct Debit',

Follow-up revisions

RevisionCommit summaryAuthorDate
r102961Should be ®, not ©. "BPAY" is a registered trademark, spotted by Minh Nguyễn...raymond10:25, 14 November 2011
r103052MFT r102807, r102942, r102953, r102960, r102961, r102943, r103009, r103023, r...awjrichards22:17, 14 November 2011
r106245MFT r102664, r102689, r102736, r102807, r102812, r102824, r102872, r102922, r...awjrichards21:26, 14 December 2011

Comments

#Comment by Jsoby (talk | contribs)   22:43, 11 November 2011

Should it really be "BPAY©"? If anything, I would expect "BPAY®", but any such mark should not be used in interface messages. (We don't write Wikipedia™ or MediaWiki™.)

#Comment by Awjrichards (talk | contribs)   01:35, 14 November 2011

There is actually a legal requirement for us to display '®' after 'BPAY' (rather than ©, but same idea). Considering this, is it ok to have 'BPAY®' as an i18n message?

#Comment by Jsoby (talk | contribs)   01:59, 14 November 2011

Why is there a requirement for BPAY, why not for PayPal or all the other stuff? Anyways, I don't really care. :P But be sure to mention why it's there in the qqq message (I can add that for this one).

#Comment by Jalexander-WMF (talk | contribs)   03:24, 14 November 2011

Not sure why but but they are very specific (and we have to run form options by them before we put it up and they will (read: Already have) kick them back if no circle r

#Comment by Awjrichards (talk | contribs)   17:09, 14 November 2011

This was fixed by raymond in r102961

Status & tagging log