r104074 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104073‎ | r104074 | r104075 >
Date:19:45, 23 November 2011
Author:yaron
Status:deferred
Tags:
Comment:
Another follow-up to r102365 - set $target_name to always be blank instead of nu, based on suggestion from Van de Bugger
Modified paths:
  • /trunk/extensions/SemanticForms/specials/SF_FormEdit.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/specials/SF_FormEdit.php
@@ -107,6 +107,10 @@
108108 $form_definition = $form_article->getContent();
109109 $form_definition = StringUtils::delimiterReplace( '<noinclude>', '</noinclude>', '', $form_definition );
110110
 111+ if ( is_null( $target_name ) ) {
 112+ $target_name = '';
 113+ }
 114+
111115 if ( $target_name === '' ) {
112116
113117 // parse the form to see if it has a 'page name' value set

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r102365strict comparators for empty stringsjeroendedauw02:25, 8 November 2011