r104001 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104000‎ | r104001 | r104002 >
Date:01:54, 23 November 2011
Author:jpostlethwaite
Status:ok (Comments)
Tags:fundraising 
Comment:
Adding translations for Donate-error.
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_common/interface.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_common/interface.i18n.php
@@ -192,6 +192,12 @@
193193 'donate_interface-error-msg-captcha-please' => "For your credit card security, please type the characters you see above.",
194194 'donate_interface-error-msg-cookies' => 'Please enable cookies in your browser.',
195195 'donate_interface-error-msg-genaricrequired' => 'This field is required',
 196+ 'donate_interface-donate-error-please' => 'Please',
 197+ 'donate_interface-donate-error-try-a-different-card' => 'try a different card',
 198+ 'donate_interface-donate-error-or-one-of-our' => 'or one of our',
 199+ 'donate_interface-donate-error-other-ways-to-give' => 'other ways to give',
 200+ 'donate_interface-donate-error-or-contact-us-at' => 'or contact us at mailto:donate@wikimedia.org.',
 201+ 'donate_interface-donate-error-thank-you-for-your-support' => 'Thank you for your support!',
196202 'php-response-declined' => 'Your transaction could not be accepted.',
197203 'donate_interface-thankyou' => 'Thank you for your donation!',
198204 'donate_interface-post-transaction' => 'Transaction details',
@@ -632,6 +638,19 @@
633639 'donate_interface-error-msg-captcha-please' => 'Message given the user if he/she has to fill out a [[w:en:CAPTCHA|CAPTCHA]] before the donation is fulfilled.',
634640 'donate_interface-error-msg-cookies' => "Error message if the user's browser has cookies disabled",
635641 'donate_interface-error-msg-genaricrequired' => 'Message displayed to a user if a field is required but not filled out when they try to submit',
 642+ 'donate_interface-donate-error-please' => 'All of the messages prefixed with "donate_interface-donate-error-" are part of a message on /index.php/Donate-error.
 643+
 644+The full message:
 645+
 646+Please try a different card or one of our other ways to give or contact us at mailto:donate@wikimedia.org.
 647+
 648+Thank you for your support!
 649+ ',
 650+ 'donate_interface-donate-error-try-a-different-card' => 'This is a link so a user can try a different card.',
 651+ 'donate_interface-donate-error-or-one-of-our' => 'Text to complete the sentence with: donate_interface-donate-error-try-a-different-card and donate_interface-donate-error-other-ways-to-give.',
 652+ 'donate_interface-donate-error-other-ways-to-give' => 'This is a link to other ways to give.',
 653+ 'donate_interface-donate-error-or-contact-us-at' => 'Contact us',
 654+ 'donate_interface-donate-error-thank-you-for-your-support' => 'Thank you for your support!',
636655 'php-response-declined' => 'Error message if the translaction was declined.',
637656 'donate_interface-thankyou' => 'A thank you for donating.',
638657 'donate_interface-post-transaction' => 'Header for transaction details after the transaction is fulfilled (receipt).',

Follow-up revisions

RevisionCommit summaryAuthorDate
r104002Changed fail page to pass uselang.jpostlethwaite01:55, 23 November 2011
r104073Fixing messages for Donate-error page. The message now uses parameters. See r...jpostlethwaite19:40, 23 November 2011
r104096MFT r104001, r104062, r104073khorn22:29, 23 November 2011
r106245MFT r102664, r102689, r102736, r102807, r102812, r102824, r102872, r102922, r...awjrichards21:26, 14 December 2011

Comments

#Comment by Jsoby (talk | contribs)   17:30, 23 November 2011

This does not work at all, sorry. This should just be one message (except for the "Thank you for your support"), with variables:

Please [$1 try a different card] or one of our [$2 other ways to give] or contact us at $3.

#Comment by Jpostlethwaite (talk | contribs)   19:43, 23 November 2011

See fix in r104073.

Status & tagging log