r104002 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r104001‎ | r104002 | r104003 >
Date:01:55, 23 November 2011
Author:jpostlethwaite
Status:ok (Comments)
Tags:fundraising 
Comment:
Changed fail page to pass uselang.
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_common/gateway.adapter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_common/gateway.adapter.php
@@ -283,7 +283,10 @@
284284 public function getFailPage() {
285285 $page = self::getGlobal( "FailPage" );
286286 if ( $page ) {
287 - $page = $this->appendLanguageAndMakeURL( $page );
 287+
 288+ $language = $this->getData_Raw( 'language' );
 289+
 290+ $page .= '?uselang=' . $language;
288291 }
289292 return $page;
290293 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r104092MFT r104002, r104089khorn21:57, 23 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r104001Adding translations for Donate-error.jpostlethwaite01:54, 23 November 2011

Comments

#Comment by Khorn (WMF) (talk | contribs)   21:44, 23 November 2011

At some point, we're going to have to deal with the "AndMakeURL" aspect of "appendLanguageAndMakeURL". For now, though, this is OK as long as we put something known to be rational in LocalSettings.php.

Status & tagging log