r103963 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103962‎ | r103963 | r103964 >
Date:21:53, 22 November 2011
Author:pgehres
Status:ok
Tags:
Comment:
A few minor fixes to the new gc form. FU r103960
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_forms/rapidhtml/RapidHtmlResources.php (modified) (history)
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/cc/cc-US.html (modified) (history)
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/js/gc.cc.js (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_forms/rapidhtml/RapidHtmlResources.php
@@ -134,8 +134,8 @@
135135 $wgResourceModules[ 'gc.form.rapidhtml.cc' ] = array(
136136 'styles' => 'css/gc.cc.css',
137137 'scripts' => array(
138 - 'js/gc.cc.js',
139 - 'js/gc.js'
 138+ 'js/gc.js',
 139+ 'js/gc.cc.js'
140140 ),
141141 'dependencies' => array( 'di.form.core.validate' ),
142142 'localBasePath' => dirname( __FILE__ ).'/../../globalcollect_gateway/forms',
Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/cc/cc-US.html
@@ -64,7 +64,7 @@
6565 <tr>
6666 <td>
6767 <dl class="">
68 - <dd class="field" style="margin-bottom: 0; margin-left: 10px;">
 68+ <dd class="field" style="margin-bottom: 0; margin-left: 0;">
6969 <ul class="options-h" id="cards" style="margin: 0;">
7070 <li><input id="cc-visa" name="cardtype" type="radio" value="visa" class="cardradio" /> <label for="cc-visa"><img alt="Visa" src="@script_path/extensions/DonationInterface/gateway_forms/includes/card-visa.png" /></label></li>
7171 <li><input id="cc-mastercard" name="cardtype" type="radio" value="mastercard" class="cardradio" /> <label for="cc-mastercard"><img alt="MasterCard" src="@script_path/extensions/DonationInterface/gateway_forms/includes/card-mastercard.png" /></label></li>
Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/js/gc.cc.js
@@ -38,8 +38,11 @@
3939 }
4040
4141 $( "#paymentContinueBtn" ).live( "click", function() {
42 - if ( validate_personal( document.paypalcontribution ) && validateAmount() ) {
43 - displayCreditCardForm()
 42+ if ( validate_personal( document.payment ) && validateAmount() ) {
 43+ $( "#payment" ).animate( { height:'314px' }, 1000 );
 44+ displayCreditCardForm();
 45+ // hide the continue button so that people don't get confused with two of them
 46+ $( "#paymentContinue" ).hide();
4447 }
4548 } );
4649

Follow-up revisions

RevisionCommit summaryAuthorDate
r103986MFT r103871, r103960, r103963, r103972, r103983khorn00:08, 23 November 2011
r103987MFT r103871, r103960, r103963, r103972, r103983khorn00:09, 23 November 2011
r103989MFT r103842, r103845, r103854, r103960, r103963, r103971, r103983khorn00:26, 23 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103960Adding new GC credit card formpgehres21:40, 22 November 2011

Status & tagging log