r103964 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103963‎ | r103964 | r103965 >
Date:21:57, 22 November 2011
Author:bsitu
Status:ok (Comments)
Tags:
Comment:
followup to r103881, remove the unnecessary field bucket since it is only used for the moodbar a/b testing
Modified paths:
  • /trunk/extensions/MoodBar/ApiFeedbackDashboardResponse.php (modified) (history)
  • /trunk/extensions/MoodBar/FeedbackResponseItem.php (modified) (history)
  • /trunk/extensions/MoodBar/sql/moodbar_feedback_response.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/ApiFeedbackDashboardResponse.php
@@ -76,7 +76,6 @@
7777 'useragent' => null,
7878 'system' => null,
7979 'locale' => null,
80 - 'bucket' => null,
8180 'token' => null,
8281 );
8382 }
@@ -99,7 +98,6 @@
10099 'response' => 'The feedback text',
101100 'anonymize' => 'Whether to hide user information',
102101 'editmode' => 'Whether or not the feedback context is in edit mode',
103 - 'bucket' => 'The testing bucket, if any',
104102 'useragent' => 'The User-Agent header of the browser',
105103 'system' => 'The operating system being used',
106104 'locale' => 'The locale in use',
Index: trunk/extensions/MoodBar/sql/moodbar_feedback_response.sql
@@ -19,8 +19,7 @@
2020 mbfr_system_type varchar(64) binary NULL, -- Operating System
2121 mbfr_user_agent varchar(255) binary NULL, -- User-Agent header
2222 mbfr_locale varchar(32) binary NULL, -- The locale of the user's browser
23 - mbfr_editing tinyint unsigned NOT NULL, -- Whether or not the user was editing
24 - mbfr_bucket varchar(128) binary NULL -- Bucket, for A/B testing
 23+ mbfr_editing tinyint unsigned NOT NULL -- Whether or not the user was editing
2524 ) /*$wgDBTableOptions*/;
2625
2726 CREATE INDEX /*i*/mbfr_mbf_id ON /*_*/moodbar_feedback_response (mbfr_mbf_id);
Index: trunk/extensions/MoodBar/FeedbackResponseItem.php
@@ -23,8 +23,7 @@
2424 'system', // Operating System
2525 'useragent' , // User-Agent header
2626 'locale', // The locale of the user's browser
27 - 'editmode', // Whether or not the user was editing
28 - 'bucket' // Bucket, for A/B testing
 27+ 'editmode' // Whether or not the user was editing
2928 );
3029 /**
3130 * Default constructor.
@@ -42,7 +41,7 @@
4342 * Factory function to create a new MBFeedbackResponseItem
4443 * @param $info Associative array of values
4544 * Valid keys: feedbackitem, user, response-text, timestamp,
46 - * useragent, system, locale, bucket
 45+ * useragent, system, locale
4746 * @return MBFeedbackItem object.
4847 */
4948 public static function create( $info ) {
@@ -94,7 +93,6 @@
9594 'useragent' => 'mbfr_user_agent',
9695 'system' => 'mbfr_system_type',
9796 'locale' => 'mbfr_locale',
98 - 'bucket' => 'mbfr_bucket',
9997 'editmode' => 'mbfr_editing',
10098 'commenter-editcount',
10199 'user-editcount'
@@ -231,7 +229,6 @@
232230 'mbfr_system_type' => $this->getProperty('system'),
233231 'mbfr_user_agent' => $this->getProperty('useragent'),
234232 'mbfr_locale' => $this->getProperty('locale'),
235 - 'mbfr_bucket' => $this->getProperty('bucket'),
236233 'mbfr_editing' => $this->getProperty('editmode')
237234 );
238235

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103881MoodBar Phase 2 - Feedback response APIbsitu01:45, 22 November 2011

Comments

#Comment by Raindrift (talk | contribs)   02:56, 23 November 2011

While this is fine for this particular revision since we can be pretty sure it's not used elsewhere, I think we have a more in-depth and cautious procedure for deprecating API parameters.

Status & tagging log