r103989 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103988‎ | r103989 | r103990 >
Date:00:26, 23 November 2011
Author:khorn
Status:deferred
Tags:
Comment:
Modified paths:
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/includes/wmlogo_blue.png (added) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/includes/wmlogo_white.png (added) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/rapidhtml/RapidHtmlResources.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php (modified) (history)
  • /branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/modules/validate_input.js (modified) (history)

Diff [purge]

Index: branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/rapidhtml/RapidHtmlResources.php
@@ -131,7 +131,22 @@
132132 'localBasePath' => dirname( __FILE__ ).'/../../globalcollect_gateway/forms',
133133 'remoteExtPath' => $wgGlobalCollectRapidHtmlRemoteExtPath,
134134 );
 135+$wgResourceModules[ 'gc.form.rapidhtml.cc' ] = array(
 136+ 'styles' => 'css/gc.cc.css',
 137+ 'scripts' => array(
 138+ 'js/gc.js',
 139+ 'js/gc.cc.js'
 140+ ),
 141+ 'dependencies' => array( 'di.form.core.validate' ),
 142+ 'localBasePath' => dirname( __FILE__ ).'/../../globalcollect_gateway/forms',
 143+ 'remoteExtPath' => $wgGlobalCollectRapidHtmlRemoteExtPath,
 144+);
135145
 146+
 147+/*************************************************************
 148+ *************************************************************
 149+ *************************************************************/
 150+
136151 // PayflowPro
137152 $wgResourceModules[ 'pfp.form.rapidhtml.webitects' ] = array(
138153 'styles' => '',
Index: branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/includes/wmlogo_blue.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/includes/wmlogo_blue.png
___________________________________________________________________
Added: svn:mime-type
139154 + image/png
Index: branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/includes/wmlogo_white.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/gateway_forms/includes/wmlogo_white.png
___________________________________________________________________
Added: svn:mime-type
140155 + image/png
Index: branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php
@@ -856,15 +856,6 @@
857857 'keys' => array(),
858858 );
859859
860 - // eWallets PayPal
861 - $this->payment_submethods['ew_paypal'] = array(
862 - 'paymentproductid' => 840,
863 - 'label' => 'eWallets: PayPal',
864 - 'group' => 'ew',
865 - 'validation' => array(),
866 - 'keys' => array(),
867 - );
868 -
869860 // eWallets WebMoney
870861 $this->payment_submethods['ew_webmoney'] = array(
871862 'paymentproductid' => 841,
@@ -1277,8 +1268,6 @@
12781269 }
12791270
12801271 $errors[ $code ] = ( $this->getGlobal( 'DisplayDebug' ) ) ? '*** ' . $message : $this->getErrorMapByCodeAndTranslate( $code );
1281 -
1282 - $this->setTransactionWMFStatus( $this->findCodeAction( 'GET_ORDERSTATUS', 'STATUSID', $code ) );
12831272 }
12841273 return $errors;
12851274 }
@@ -1298,13 +1287,13 @@
12991288 $transaction = $this->getCurrentTransaction();
13001289
13011290 $this->getTransactionStatus();
1302 -
 1291+
13031292 switch ( $transaction ) {
13041293 case 'INSERT_ORDERWITHPAYMENT':
13051294 $data = $this->xmlChildrenToArray( $response, 'ROW' );
13061295 $data['ORDER'] = $this->xmlChildrenToArray( $response, 'ORDER' );
13071296 $data['PAYMENT'] = $this->xmlChildrenToArray( $response, 'PAYMENT' );
1308 -
 1297+
13091298 // WMFStatus will already be set if the transaction was unable to communicate properly.
13101299 if ( $this->getTransactionStatus() ) {
13111300 $this->setTransactionWMFStatus( $this->findCodeAction( 'GET_ORDERSTATUS', 'STATUSID', $data['STATUSID'] ) );
Property changes on: branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php
___________________________________________________________________
Modified: svn:mergeinfo
13121301 Merged /trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php:r103842,103845,103854,103960,103963,103971,103983
Index: branches/fundraising/deployment/payments_1.17/extensions/DonationInterface/modules/validate_input.js
@@ -56,7 +56,13 @@
5757 error = ( amount == null || isNaN( amount ) || amount.value <= 0 );
5858
5959 // Check amount is at least the minimum
60 - var currency_code = $( 'input[name="currency_code"]' ).val();
 60+ var currency_code = '';
 61+ if( $( 'input[name="currency_code"]' ).length ){
 62+ currency_code = $( 'input[name="currency_code"]' ).val();
 63+ }
 64+ if( $( 'select[name="currency_code"]' ).length ){
 65+ currency_code = $( 'select[name="currency_code"]' ).val();
 66+ }
6167 if ( typeof( wgCurrencyMinimums[currency_code] ) == 'undefined' ) {
6268 wgCurrencyMinimums[currency_code] = 1;
6369 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103842Checking in fix to prevent setTransactionWMFStatus() from taking a null value.jpostlethwaite22:01, 21 November 2011
r103845Removed duplicate payment_submethod: ew_paypal. See r103415.jpostlethwaite22:19, 21 November 2011
r103854adding webmoney logosjamesur22:51, 21 November 2011
r103960Adding new GC credit card formpgehres21:40, 22 November 2011
r103963A few minor fixes to the new gc form. FU r103960pgehres21:53, 22 November 2011
r103971Removed findCodeAction() from getResponseData().jpostlethwaite22:50, 22 November 2011
r103983Fixes for ew-webmoneypgehres23:51, 22 November 2011

Status & tagging log