r103971 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103970‎ | r103971 | r103972 >
Date:22:50, 22 November 2011
Author:jpostlethwaite
Status:ok
Tags:
Comment:
Removed findCodeAction() from getResponseData().
Modified paths:
  • /trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php
@@ -1268,13 +1268,6 @@
12691269 }
12701270
12711271 $errors[ $code ] = ( $this->getGlobal( 'DisplayDebug' ) ) ? '*** ' . $message : $this->getErrorMapByCodeAndTranslate( $code );
1272 -
1273 - $codeAction = $this->findCodeAction( 'GET_ORDERSTATUS', 'STATUSID', $code );
1274 -
1275 - if ( !empty( $codeAction ) ) {
1276 -
1277 - $this->setTransactionWMFStatus( $codeAction );
1278 - }
12791272 }
12801273 return $errors;
12811274 }
@@ -1294,13 +1287,13 @@
12951288 $transaction = $this->getCurrentTransaction();
12961289
12971290 $this->getTransactionStatus();
1298 -
 1291+
12991292 switch ( $transaction ) {
13001293 case 'INSERT_ORDERWITHPAYMENT':
13011294 $data = $this->xmlChildrenToArray( $response, 'ROW' );
13021295 $data['ORDER'] = $this->xmlChildrenToArray( $response, 'ORDER' );
13031296 $data['PAYMENT'] = $this->xmlChildrenToArray( $response, 'PAYMENT' );
1304 -
 1297+
13051298 // WMFStatus will already be set if the transaction was unable to communicate properly.
13061299 if ( $this->getTransactionStatus() ) {
13071300 $this->setTransactionWMFStatus( $this->findCodeAction( 'GET_ORDERSTATUS', 'STATUSID', $data['STATUSID'] ) );

Follow-up revisions

RevisionCommit summaryAuthorDate
r103989MFT r103842, r103845, r103854, r103960, r103963, r103971, r103983khorn00:26, 23 November 2011

Status & tagging log