r103842 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103841‎ | r103842 | r103843 >
Date:22:01, 21 November 2011
Author:jpostlethwaite
Status:resolved (Comments)
Tags:
Comment:
Checking in fix to prevent setTransactionWMFStatus() from taking a null value.
Modified paths:
  • /trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php
@@ -1278,7 +1278,12 @@
12791279
12801280 $errors[ $code ] = ( $this->getGlobal( 'DisplayDebug' ) ) ? '*** ' . $message : $this->getErrorMapByCodeAndTranslate( $code );
12811281
1282 - $this->setTransactionWMFStatus( $this->findCodeAction( 'GET_ORDERSTATUS', 'STATUSID', $code ) );
 1282+ $codeAction = $this->findCodeAction( 'GET_ORDERSTATUS', 'STATUSID', $code );
 1283+
 1284+ if ( !empty( $codeAction ) ) {
 1285+
 1286+ $this->setTransactionWMFStatus( $codeAction );
 1287+ }
12831288 }
12841289 return $errors;
12851290 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r103989MFT r103842, r103845, r103854, r103960, r103963, r103971, r103983khorn00:26, 23 November 2011

Comments

#Comment by Khorn (WMF) (talk | contribs)   23:59, 22 November 2011

Resolved in r103971.

Status & tagging log