r99167 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r99166‎ \| r99167 \| r99168 >
Date:	23:20, 6 October 2011
Author:	brion
Status:	ok
Tags:
Comment:	* (bug 31415) Fix regression: 'noicon' works again for OggHandler Followup to r87923 and to ... whatever started using validateParam. :) 'noicon' parameter wasn't being validated, so got ignored.
Modified paths:	/trunk/extensions/OggHandler/OggHandler_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OggHandler/OggHandler_body.php
—	—	@@ -32,6 +32,9 @@
33	33	}
34	34	return true;
35	35	}
	36	+ if ( $name == 'noicon' ) {
	37	+ return true;
	38	+ }
36	39	return false;
37	40	}
38	41

Follow-up revisions

Revision	Commit summary	Author	Date
r99985	MFT r99167	demon	22:19, 16 October 2011
r100383	REL1_18 MFT r97886, r97899, r97969, r98179, r98497, r98654, r98773, r98801, r...	reedy	21:36, 20 October 2011

Past revisions this follows-up on

Revision	Commit summary	Author	Date
r87923	Add support for the Height parameter for OggHandler. Fixes bug 28886...	hartman	19:41, 12 May 2011

Status & tagging log

21:36, 20 October 2011 Reedy (talk | contribs) changed the tags for r99167 [removed: 1.18]
22:18, 16 October 2011 😂 (talk | contribs) changed the tags for r99167 [removed: 1.18wmf1]
22:18, 16 October 2011 😂 (talk | contribs) changed the status of r99167 [removed: new added: ok]
23:21, 6 October 2011 Brion VIBBER (talk | contribs) changed the tags for r99167 [added: 1.18,1.18wmf1]