r99022 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99021‎ | r99022 | r99023 >
Date:18:38, 5 October 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
Actually fix bug 31354 this time (hopefully): expand URLs in the permalink dialog if wgServer is protocol-relative
Modified paths:
  • /trunk/extensions/LiquidThreads/lqt.js (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/lqt.js
@@ -835,6 +835,9 @@
836836 var linkTitle = thread.find('.lqt-thread-title-metadata').val();
837837 var linkURL = wgArticlePath.replace( "$1", linkTitle.replace(/ /g, '_' ) );
838838 linkURL = wgServer + linkURL;
 839+ if ( linkURL.substr( 0, 2 ) == '//' ) {
 840+ linkURL = window.location.protocol + linkURL;
 841+ }
839842 liquidThreads.showLinkWindow( linkTitle, linkURL );
840843 },
841844

Follow-up revisions

RevisionCommit summaryAuthorDate
r990241.18wmf1: MFT r99022catrope18:40, 5 October 2011
r102517REL1_18 MFT r98432, r99022reedy14:51, 9 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99016(bug 31354) Make permalinks canonical, not protocol-relative.catrope17:53, 5 October 2011

Comments

#Comment by G.Hagedorn (talk | contribs)   00:03, 6 October 2011

applied to 1.18wmf1, please consider tagging 1.18 as well.

Status & tagging log