r99021 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99020‎ | r99021 | r99022 >
Date:18:37, 5 October 2011
Author:brion
Status:ok (Comments)
Tags:
Comment:
* (bug 31380) Fix style regression on Special:Allmessages

Table cells for customized messages were missing the classes used to style the default & actual text differently. Got lost in r90334: added dir/lang attributes for the language but accidentally left out the classes.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialAllmessages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialAllmessages.php
@@ -409,12 +409,12 @@
410410 }
411411
412412 function getCellAttrs( $field, $value ){
413 - if( $field != 'am_title' ) {
414 - return array( 'lang' => $this->langcode, 'dir' => $this->lang->getDir() );
415 - } elseif( $this->mCurrentRow->am_customised && $field == 'am_title' ) {
 413+ if( $this->mCurrentRow->am_customised && $field == 'am_title' ){
416414 return array( 'rowspan' => '2', 'class' => $field );
 415+ } else if( $field == 'am_title' ) {
 416+ return array( 'class' => $field );
417417 } else {
418 - return array( 'class' => $field );
 418+ return array( 'lang' => $this->langcode, 'dir' => $this->lang->getDir(), 'class' => $field );
419419 }
420420 }
421421

Follow-up revisions

RevisionCommit summaryAuthorDate
r99023MFT r99021: fix bug 31380 (regression from r90334)brion18:39, 5 October 2011
r99039MFT r99021demon19:56, 5 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90334Follow-up to r90265: directionality improvements as part of bug 6100 (under $...robin13:12, 18 June 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   18:42, 5 October 2011

Tagging for 1.18wmf1 merge; not doing it myself to avoid confusion about whether it's been pushed.

#Comment by 😂 (talk | contribs)   19:57, 5 October 2011

Done & done.

Status & tagging log