r102517 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102516‎ | r102517 | r102518 >
Date:14:51, 9 November 2011
Author:reedy
Status:ok
Tags:
Comment:
REL1_18 MFT r98432, r99022
Modified paths:
  • /branches/REL1_18/extensions (modified) (history)
  • /branches/REL1_18/extensions/LiquidThreads (modified) (history)
  • /branches/REL1_18/extensions/LiquidThreads/lqt.js (modified) (history)
  • /branches/REL1_18/extensions/WikiEditor (modified) (history)
  • /branches/REL1_18/extensions/WikiEditor/WikiEditor.php (modified) (history)
  • /branches/REL1_18/extensions/WikiEditor/modules/ext.wikiEditor.toolbar.hideSig.js (modified) (history)

Diff [purge]

Index: branches/REL1_18/extensions/LiquidThreads/lqt.js
@@ -835,6 +835,9 @@
836836 var linkTitle = thread.find('.lqt-thread-title-metadata').val();
837837 var linkURL = wgArticlePath.replace( "$1", linkTitle.replace(/ /g, '_' ) );
838838 linkURL = wgServer + linkURL;
 839+ if ( linkURL.substr( 0, 2 ) == '//' ) {
 840+ linkURL = window.location.protocol + linkURL;
 841+ }
839842 liquidThreads.showLinkWindow( linkTitle, linkURL );
840843 },
841844
Property changes on: branches/REL1_18/extensions/LiquidThreads
___________________________________________________________________
Modified: svn:mergeinfo
842845 Merged /trunk/extensions/LiquidThreads:r99022
Index: branches/REL1_18/extensions/WikiEditor/WikiEditor.php
@@ -504,8 +504,5 @@
505505 ),
506506 'ext.wikiEditor.toolbar.hideSig' => $wikiEditorTpl + array(
507507 'scripts' => 'ext.wikiEditor.toolbar.hideSig.js',
508 - 'dependencies' => array(
509 - 'ext.wikiEditor',
510 - )
511508 ),
512509 );
Index: branches/REL1_18/extensions/WikiEditor/modules/ext.wikiEditor.toolbar.hideSig.js
@@ -2,7 +2,10 @@
33 * Remove the signature button if the main namespace is edited.
44 */
55 $( document ).ready( function() {
6 - if ( !$.wikiEditor.isSupported( $.wikiEditor.modules.toolbar ) ) {
 6+ // This module is designed not to depend on ext.wikiEditor or jquery.wikiEditor.
 7+ // Removing this dependency fixed various bugs, but it does mean that we have to
 8+ // account for the situation where $.wikiEditor is not present
 9+ if ( !$.wikiEditor || !$.wikiEditor.isSupported( $.wikiEditor.modules.toolbar ) ) {
710 return;
811 }
912 if ( $( 'body' ).hasClass( 'ns-0' ) ) {
Property changes on: branches/REL1_18/extensions/WikiEditor
___________________________________________________________________
Modified: svn:mergeinfo
1013 Merged /trunk/extensions/WikiEditor:r98432,99022
Property changes on: branches/REL1_18/extensions
___________________________________________________________________
Modified: svn:mergeinfo
1114 Merged /trunk/extensions:r98432,99022

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98432WikiEditor: Fix bug where ext.wikiEditor would load and wrap the textarea eve...catrope19:04, 29 September 2011
r99022Actually fix bug 31354 this time (hopefully): expand URLs in the permalink di...catrope18:38, 5 October 2011

Status & tagging log