r99023 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99022‎ | r99023 | r99024 >
Date:18:39, 5 October 2011
Author:brion
Status:ok
Tags:
Comment:
MFT r99021: fix bug 31380 (regression from r90334)
Modified paths:
  • /branches/REL1_18/phase3/includes/specials/SpecialAllmessages.php (modified) (history)

Diff [purge]

Index: branches/REL1_18/phase3/includes/specials/SpecialAllmessages.php
@@ -405,12 +405,12 @@
406406 }
407407
408408 function getCellAttrs( $field, $value ){
409 - if( $field != 'am_title' ) {
410 - return array( 'lang' => $this->langcode, 'dir' => $this->lang->getDir() );
411 - } elseif( $this->mCurrentRow->am_customised && $field == 'am_title' ) {
 409+ if( $this->mCurrentRow->am_customised && $field == 'am_title' ){
412410 return array( 'rowspan' => '2', 'class' => $field );
 411+ } else if( $field == 'am_title' ) {
 412+ return array( 'class' => $field );
413413 } else {
414 - return array( 'class' => $field );
 414+ return array( 'lang' => $this->langcode, 'dir' => $this->lang->getDir(), 'class' => $field );
415415 }
416416 }
417417

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90334Follow-up to r90265: directionality improvements as part of bug 6100 (under $...robin13:12, 18 June 2011
r99021* (bug 31380) Fix style regression on Special:Allmessages...brion18:37, 5 October 2011

Status & tagging log