r99039 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r99038‎ | r99039 | r99040 >
Date:19:56, 5 October 2011
Author:demon
Status:ok
Tags:
Comment:
MFT r99021
Modified paths:
  • /branches/wmf/1.18wmf1/includes/specials/SpecialAllmessages.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/specials/SpecialAllmessages.php
——@@ -405,12 +405,12 @@
406406 }
407407
408408 function getCellAttrs( $field, $value ){
409 - if( $field != 'am_title' ) {
410 - return array( 'lang' => $this->langcode, 'dir' => $this->lang->getDir() );
411 - } elseif( $this->mCurrentRow->am_customised && $field == 'am_title' ) {
 409+ if( $this->mCurrentRow->am_customised && $field == 'am_title' ){
412410 return array( 'rowspan' => '2', 'class' => $field );
 411+ } else if( $field == 'am_title' ) {
 412+ return array( 'class' => $field );
413413 } else {
414 - return array( 'class' => $field );
 414+ return array( 'lang' => $this->langcode, 'dir' => $this->lang->getDir(), 'class' => $field );
415415 }
416416 }
417417
Property changes on: branches/wmf/1.18wmf1/includes/specials/SpecialAllmessages.php
___________________________________________________________________
Added: svn:mergeinfo
418418 Merged /branches/REL1_15/phase3/includes/specials/SpecialAllmessages.php:r51646
419419 Merged /branches/sqlite/includes/specials/SpecialAllmessages.php:r58211-58321
420420 Merged /trunk/phase3/includes/specials/SpecialAllmessages.php:r92580,92634,92713,92762,92765,92791,92854,92884,92886-92887,92894,92898,92907,92932,92958,93141,93149,93151,93233-93234,93258,93266,93303,93516-93518,93818-93822,93847,93858,93891,93935-93936,94058,94062,94068,94107,94155,94235,94346,94372,94422,94425,94444,94448,94456,94498,94601,94630,94728,94825,94862,94995-94997,95042,95155,95332,95410,95442,95468,95601,95812,98578,98598,98656,99021
421421 Merged /branches/wmf-deployment/includes/specials/SpecialAllmessages.php:r53381,56967

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99021* (bug 31380) Fix style regression on Special:Allmessages...brion18:37, 5 October 2011

Status & tagging log