r97285 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97284‎ | r97285 | r97286 >
Date:15:05, 16 September 2011
Author:jeroendedauw
Status:reverted
Tags:
Comment:
use style args that are escaped; not strictrly needed here as the vars have already been sanitized, but good practice won't hurt
Modified paths:
  • /trunk/extensions/SemanticMaps/includes/queryprinters/SM_MapPrinter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/includes/queryprinters/SM_MapPrinter.php
@@ -207,7 +207,12 @@
208208 'div',
209209 array(
210210 'id' => $mapName,
211 - 'style' => "width: {$params['width']}; height: {$params['height']}; background-color: #cccccc; overflow: hidden;",
 211+ 'style' => array(
 212+ 'width' => $params['width'],
 213+ 'height' => $params['height'],
 214+ 'background-color' => '#cccccc',
 215+ 'overflow' => 'hidden'
 216+ )
212217 ),
213218 wfMsg( 'maps-loading-map' )
214219 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r97293revert r97285; interface is proposed but does not exist yet - I failedjeroendedauw15:23, 16 September 2011

Status & tagging log