r97286 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r97285‎ | r97286 | r97287 >
Date:15:05, 16 September 2011
Author:jeroendedauw
Status:reverted
Tags:
Comment:
use style args that are escaped; not strictrly needed here as the vars have already been sanitized, but good practice won't hurt
Modified paths:
  • /trunk/extensions/SemanticResultFormats/TagCloud/SRF_TagCloud.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticResultFormats/TagCloud/SRF_TagCloud.php
——@@ -219,7 +219,7 @@
220220 foreach ( $tags as $name => $size ) {
221221 $htmlTags[] = Html::rawElement(
222222 'span',
223 - array( 'style' => "font-size:$size%" ),
 223+ array( 'style' => array( 'font-size' => "$size%" ) ),
224224 $this->tagsHtml[$name]
225225 );
226226 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r97292revert r97286; interface is proposed but does not exist yet - I failedjeroendedauw15:21, 16 September 2011

Status & tagging log