r97293 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97292‎ | r97293 | r97294 >
Date:15:23, 16 September 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
revert r97285; interface is proposed but does not exist yet - I failed
Modified paths:
  • /trunk/extensions/SemanticMaps/includes/queryprinters/SM_MapPrinter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/includes/queryprinters/SM_MapPrinter.php
@@ -207,12 +207,7 @@
208208 'div',
209209 array(
210210 'id' => $mapName,
211 - 'style' => array(
212 - 'width' => $params['width'],
213 - 'height' => $params['height'],
214 - 'background-color' => '#cccccc',
215 - 'overflow' => 'hidden'
216 - )
 211+ 'style' => "width: {$params['width']}; height: {$params['height']}; background-color: #cccccc; overflow: hidden;",
217212 ),
218213 wfMsg( 'maps-loading-map' )
219214 );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97285use style args that are escaped; not strictrly needed here as the vars have a...jeroendedauw15:05, 16 September 2011