r97284 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97283‎ | r97284 | r97285 >
Date:15:04, 16 September 2011
Author:jeroendedauw
Status:reverted
Tags:
Comment:
use style args that are escaped; not strictrly needed here as the vars have already been sanitized, but good practice won't hurt
Modified paths:
  • /trunk/extensions/Maps/includes/features/Maps_BaseMap.php (modified) (history)
  • /trunk/extensions/Maps/includes/features/Maps_BasePointMap.php (modified) (history)
  • /trunk/extensions/Maps/includes/services/OSM/Maps_OSMDispMap.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/includes/services/OSM/Maps_OSMDispMap.php
@@ -27,7 +27,11 @@
2828 'iframe',
2929 array(
3030 'id' => $mapName,
31 - 'style' => "width: {$params['width']}; height: {$params['height']}; clear: both;",
 31+ 'style' => array(
 32+ 'width' => $params['width'],
 33+ 'height' => $params['height'],
 34+ 'clear' => 'both'
 35+ ),
3236 'src' => "http://toolserver.org/~kolossos/openlayers/kml-on-ol.php?zoom={$params['zoom']}&lat={$params['centre']['lat']}&lon={$params['centre']['lon']}&lang=$lang&thumbs=$thumbs&photo=$photos"
3337 ),
3438 wfMsg( 'maps-loading-map' )
Index: trunk/extensions/Maps/includes/features/Maps_BasePointMap.php
@@ -76,7 +76,12 @@
7777 'div',
7878 array(
7979 'id' => $mapName,
80 - 'style' => "width: {$params['width']}; height: {$params['height']}; background-color: #cccccc; overflow: hidden;",
 80+ 'style' => array(
 81+ 'width' => $params['width'],
 82+ 'height' => $params['height'],
 83+ 'background-color' => '#cccccc',
 84+ 'overflow' => 'hidden'
 85+ )
8186 ),
8287 wfMsg( 'maps-loading-map' )
8388 );
Index: trunk/extensions/Maps/includes/features/Maps_BaseMap.php
@@ -100,7 +100,12 @@
101101 'div',
102102 array(
103103 'id' => $mapName,
104 - 'style' => "width: {$params['width']}; height: {$params['height']}; background-color: #cccccc; overflow: hidden;",
 104+ 'style' => array(
 105+ 'width' => $params['width'],
 106+ 'height' => $params['height'],
 107+ 'background-color' => '#cccccc',
 108+ 'overflow' => 'hidden'
 109+ )
105110 ),
106111 wfMsg( 'maps-loading-map' )
107112 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r97294revert r97284; interface is proposed but does not exist yet - I failedjeroendedauw15:24, 16 September 2011

Status & tagging log