r95601 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95600‎ | r95601 | r95602 >
Date:15:50, 27 August 2011
Author:ariel
Status:ok (Comments)
Tags:
Comment:
replace WfDie()
Modified paths:
  • /trunk/phase3/includes/Export.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Export.php
@@ -739,7 +739,7 @@
740740 function closeRenameAndReopen( $newname ) {
741741 if ( is_array($newname) ) {
742742 if (count($newname) > 1) {
743 - WfDie("Export closeRenameAndReopen: passed multiple argumnts for rename of single file\n");
 743+ throw new MWException("Export closeRenameAndReopen: passed multiple argumnts for rename of single file\n");
744744 }
745745 else {
746746 $newname = $newname[0];
@@ -755,7 +755,7 @@
756756 function rename( $newname ) {
757757 if ( is_array($newname) ) {
758758 if (count($newname) > 1) {
759 - WfDie("Export closeRenameAndReopen: passed multiple argumnts for rename of single file\n");
 759+ throw new MWException("Export closeRenameAndReopen: passed multiple argumnts for rename of single file\n");
760760 }
761761 else {
762762 $newname = $newname[0];
@@ -796,7 +796,7 @@
797797 function closeRenameAndReopen( $newname ) {
798798 if ( is_array($newname) ) {
799799 if (count($newname) > 1) {
800 - WfDie("Export closeRenameAndReopen: passed multiple argumnts for rename of single file\n");
 800+ throw new MWException("Export closeRenameAndReopen: passed multiple argumnts for rename of single file\n");
801801 }
802802 else {
803803 $newname = $newname[0];
@@ -814,7 +814,7 @@
815815 function rename( $newname ) {
816816 if ( is_array($newname) ) {
817817 if (count($newname) > 1) {
818 - WfDie("Export closeRenameAndReopen: passed multiple argumnts for rename of single file\n");
 818+ throw new MWException("Export closeRenameAndReopen: passed multiple argumnts for rename of single file\n");
819819 }
820820 else {
821821 $newname = $newname[0];
@@ -865,7 +865,7 @@
866866 function closeRenameAndReopen( $newname ) {
867867 if ( is_array($newname) ) {
868868 if (count($newname) > 1) {
869 - WfDie("Export closeRenameAndReopen: passed multiple argumnts for rename of single file\n");
 869+ throw new MWException("Export closeRenameAndReopen: passed multiple argumnts for rename of single file\n");
870870 }
871871 else {
872872 $newname = $newname[0];
@@ -883,7 +883,7 @@
884884 function rename( $newname ) {
885885 if ( is_array($newname) ) {
886886 if (count($newname) > 1) {
887 - WfDie("Export closeRenameAndReopen: passed multiple argumnts for rename of single file\n");
 887+ throw new MWException("Export closeRenameAndReopen: passed multiple argumnts for rename of single file\n");
888888 }
889889 else {
890890 $newname = $newname[0];

Follow-up revisions

RevisionCommit summaryAuthorDate
r964651.17wmf1: MFT r94135, r95260, r95311, r95601, r95790, r96434catrope18:33, 7 September 2011
r96556MFT r95260, r95272, r95288, r95290, r95443, r95601, r95604, r95634, r95720, r...reedy12:28, 8 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95260add functions that support close and rename of output files as they are being...ariel22:01, 22 August 2011

Comments

#Comment by Hashar (talk | contribs)   17:58, 28 August 2011

readding 1.18. I did not merge it since I lack the time to resolve the conflict.

Status & tagging log