r95720 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95719‎ | r95720 | r95721 >
Date:22:48, 29 August 2011
Author:ariel
Status:ok
Tags:
Comment:
check the checkpoint related options only if we specified checkpoints, duh
Modified paths:
  • /trunk/phase3/maintenance/dumpTextPass.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/dumpTextPass.php
@@ -245,13 +245,15 @@
246246 }
247247 }
248248
249 - $filenameList = $this->egress->getFilename();
250 - if (! is_array($filenameList)) {
251 - $filenameList = array( $filenameList );
 249+ if ($this->checkpointFiles) {
 250+ $filenameList = $this->egress->getFilename();
 251+ if (! is_array($filenameList)) {
 252+ $filenameList = array( $filenameList );
 253+ }
 254+ if (count($filenameList) != count($this->checkpointFiles)) {
 255+ wfDie("One checkpointfile must be specified for each output option, if maxtime is used.\n");
 256+ }
252257 }
253 - if (count($filenameList) != count($this->checkpointFiles)) {
254 - wfDie("One checkpointfile must be specified for each output option, if maxtime is used.\n");
255 - }
256258 }
257259
258260 function readDump( $input ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r96556MFT r95260, r95272, r95288, r95290, r95443, r95601, r95604, r95634, r95720, r...reedy12:28, 8 September 2011

Status & tagging log