r94135 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94134‎ | r94135 | r94136 >
Date:19:18, 9 August 2011
Author:robin
Status:ok (Comments)
Tags:
Comment:
Use workaround so the "What's this?" link goes to a page depending on the content language rather than the user language
Modified paths:
  • /trunk/extensions/ArticleFeedback/ArticleFeedback.hooks.php (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/ArticleFeedback.hooks.php
@@ -306,6 +306,7 @@
307307 $vars['wgArticleFeedbackTracking'] = $wgArticleFeedbackTracking;
308308 $vars['wgArticleFeedbackOptions'] = $wgArticleFeedbackOptions;
309309 $vars['wgArticleFeedbackNamespaces'] = $wgArticleFeedbackNamespaces;
 310+ $vars['wgArticleFeedbackWhatsThisPage'] = wfMsgForContent( 'articlefeedback-form-panel-explanation-link' );
310311 return true;
311312 }
312313
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
@@ -505,7 +505,7 @@
506506 .end()
507507 .find( '.articleFeedback-explanation-link' )
508508 .attr( 'href', mw.config.get( 'wgArticlePath' ).replace(
509 - '$1', mw.msg( 'articlefeedback-form-panel-explanation-link' )
 509+ '$1', mw.config.get( 'wgArticleFeedbackWhatsThisPage' )
510510 ) )
511511 .end()
512512 .find( '.articleFeedback-pitches' )

Follow-up revisions

RevisionCommit summaryAuthorDate
r964651.17wmf1: MFT r94135, r95260, r95311, r95601, r95790, r96434catrope18:33, 7 September 2011

Comments

#Comment by Krinkle (talk | contribs)   21:45, 26 August 2011

Fixes bug 30590

Status & tagging log