r95790 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r95789‎ | r95790 | r95791 >
Date:16:22, 30 August 2011
Author:siebrand
Status:ok
Tags:
Comment:
(bug 30611) Improve WikiEditor localization for Arabic script languages. Patch by Amir E. Aharoni.

Split the Arabic section in jquery.wikiEditor.toolbar.config.js into Arabic and Arabic extended. Arabic contains the core 28-letter alphabet, special letters for the Arabic language, vowels, punctuation and digits. "Arabic extended" contains most of the other letters and signs that are used by languages such as Arabic, Urdu, Balochi, etc.
Modified paths:
  • /trunk/extensions/WikiEditor/WikiEditor.i18n.php (modified) (history)
  • /trunk/extensions/WikiEditor/WikiEditor.php (modified) (history)
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.config.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiEditor/WikiEditor.php
——@@ -311,6 +311,7 @@
312312 'wikieditor-toolbar-characters-page-greek',
313313 'wikieditor-toolbar-characters-page-cyrillic',
314314 'wikieditor-toolbar-characters-page-arabic',
 315+ 'wikieditor-toolbar-characters-page-arabicextended',
315316 'wikieditor-toolbar-characters-page-persian',
316317 'wikieditor-toolbar-characters-page-hebrew',
317318 'wikieditor-toolbar-characters-page-bangla',
Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.config.js
——@@ -650,19 +650,108 @@
651651 "\u042f", "\u044f"
652652 ]
653653 },
 654+ // The core 28-letter alphabet, special letters for the Arabic language,
 655+ // vowels, punctuation, digits.
 656+ // Names of letters are written as in the Unicode charts.
654657 'arabic': {
655658 'labelMsg': 'wikieditor-toolbar-characters-page-arabic',
656659 'layout': 'characters',
657660 'language': 'ar',
658661 'direction': 'rtl',
659662 'characters': [
660 - "\u061b", "\u061f", "\u0621", "\u0622", "\u0623", "\u0624", "\u0625", "\u0626", "\u0627",
661 - "\u0628", "\u0629", "\u062a", "\u062b", "\u062c", "\u062d", "\u062e", "\u062f", "\u0630",
662 - "\u0631", "\u0632", "\u0633", "\u0634", "\u0635", "\u0636", "\u0637", "\u0638", "\u0639",
663 - "\u063a", "\u0641", "\u0642", "\u0643", "\u0644", "\u0645", "\u0646", "\u0647", "\u0648",
664 - "\u0649", "\u064a", "\u060c", "\u067e", "\u0686", "\u0698", "\u06af", "\u06ad"
 663+ // core alphabet
 664+ "\u0627", "\u0628", "\u062a", "\u062b", "\u062c", "\u062d", "\u062e", "\u062f",
 665+ "\u0630", "\u0631", "\u0632", "\u0633", "\u0634", "\u0635", "\u0636", "\u0637",
 666+ "\u0638", "\u0639", "\u063a", "\u0641", "\u0642", "\u0643", "\u0644", "\u0645",
 667+ "\u0646", "\u0647", "\u0648", "\u064a",
 668+ // special letters for the Arabic language
 669+ "\u0621", // Hamza
 670+ "\u0622", "\u0623", "\u0625", "\u0671", // Alef
 671+ "\u0624", // Waw hamza
 672+ "\u0626", // Yeh hamza
 673+ "\u0649", // Alef maksura
 674+ "\u0629", // Teh marbuta
 675+ // vowels
 676+ "\u064E", "\u064F", "\u0650", "\u064B", "\u064C", "\u064D", "\u0651", "\u0652",
 677+ "\u0670",
 678+ // punctuation
 679+ "\u060c", "\u061b", "\u061f", "\u0640",
 680+ // digits
 681+ "\u0660", "\u0661", "\u0662", "\u0663", "\u0664", "\u0665", "\u0666", "\u0667",
 682+ "\u0668", "\u0669", "\u066A", "\u066B", "\u066C", "\u066D"
665683 ]
666684 },
 685+ // Characters for languages other than Arabic.
 686+ 'arabicextended': {
 687+ 'labelMsg': 'wikieditor-toolbar-characters-page-arabicextended',
 688+ 'layout': 'characters',
 689+ 'language': 'ar',
 690+ 'direction': 'rtl',
 691+ 'characters': [
 692+ // Alef
 693+ "\u0672", "\u0673", "\u0674", "\u0675", "\u0773", "\u0774",
 694+ // Beh
 695+ "\u066E", "\u067B", "\u067E", "\u0680", "\u0750", "\u0751", "\u0752", "\u0753",
 696+ "\u0754", "\u0755", "\u0756",
 697+ // Teh
 698+ "\u0679", "\u067A", "\u067C", "\u067D", "\u067F",
 699+ // Jeem
 700+ "\u0681", "\u0682", "\u0683", "\u0684", "\u0685", "\u0686", "\u0687", "\u06BF",
 701+ // Hah
 702+ "\u0757", "\u0758", "\u076E", "\u076F", "\u0772", "\u077C",
 703+ // Dal
 704+ "\u0688", "\u0689", "\u068A", "\u068B", "\u068C", "\u068D", "\u068E", "\u068F",
 705+ "\u0690", "\u06EE", "\u0759", "\u075A",
 706+ // Reh
 707+ "\u0691", "\u0692", "\u0693", "\u0694", "\u0695", "\u0696", "\u0697", "\u0698",
 708+ "\u0699", "\u06EF", "\u075B", "\u076B", "\u076C", "\u0771",
 709+ // Seen
 710+ "\u069A", "\u069B", "\u069C", "\u077D",
 711+ // Sheen
 712+ "\u06FA", "\u075C", "\u076D", "\u0770", "\u077E",
 713+ // Sad
 714+ "\u069D", "\u069E",
 715+ // Dad
 716+ "\u06FB",
 717+ // Tah
 718+ "\u069F",
 719+ // Ain
 720+ "\u06A0", "\u075D", "\u075E", "\u075F",
 721+ // Ghain
 722+ "\u06FC",
 723+ // Feh
 724+ "\u06A1", "\u06A2", "\u06A3", "\u06A4", "\u06A5", "\u06A6", "\u0760", "\u0761",
 725+ // Qaf
 726+ "\u066F", "\u06A7", "\u06A8",
 727+ // Kaf
 728+ "\u063B", "\u063C", "\u06A9", "\u06AA", "\u06AB", "\u06AC", "\u06AD", "\u06AE",
 729+ "\u06AF", "\u06B0", "\u06B1", "\u06B2", "\u06B3", "\u06B4", "\u0762", "\u0763",
 730+ "\u0764", "\u077F",
 731+ // Lam
 732+ "\u06B5", "\u06B6", "\u06B7", "\u06B8", "\u076A",
 733+ // Meem
 734+ "\u0765", "\u0766",
 735+ // Noon
 736+ "\u06B9", "\u06BA", "\u06BB", "\u06BC", "\u06BD", "\u0767", "\u0768", "\u0769",
 737+ // Heh
 738+ "\u06BE", "\u06C0", "\u06C1", "\u06C2", "\u06C3", "\u06D5", "\u06FF",
 739+ // Waw
 740+ "\u0676", "\u0677", "\u06C4", "\u06C5", "\u06C6", "\u06C7", "\u06C8", "\u06C9",
 741+ "\u06CA", "\u06CB", "\u06CF", "\u0778", "\u0779",
 742+ // Yeh
 743+ "\u0620", "\u063D", "\u063E", "\u063F", "\u0678", "\u06CC", "\u06CD", "\u06CE",
 744+ "\u06D0", "\u06D1", "\u06D2", "\u06D3", "\u0775", "\u0776", "\u0777", "\u077A",
 745+ "\u077B",
 746+ // diacritics
 747+ "\u0656", "\u0657", "\u0658", "\u0659", "\u065A", "\u065B", "\u065C", "\u065D",
 748+ "\u065E", "\u065F",
 749+ // special punctuation
 750+ "\u06D4", "\u06FD", "\u06FE",
 751+ // special digits
 752+ "\u06F0", "\u06F1", "\u06F2", "\u06F3", "\u06F4", "\u06F5", "\u06F6", "\u06F7",
 753+ "\u06F8", "\u06F9",
 754+ ]
 755+ },
667756 'hebrew': {
668757 'labelMsg': 'wikieditor-toolbar-characters-page-hebrew',
669758 'layout': 'characters',
Index: trunk/extensions/WikiEditor/WikiEditor.i18n.php
——@@ -180,6 +180,7 @@
181181 'wikieditor-toolbar-characters-page-greek' => 'Greek',
182182 'wikieditor-toolbar-characters-page-cyrillic' => 'Cyrillic',
183183 'wikieditor-toolbar-characters-page-arabic' => 'Arabic',
 184+ 'wikieditor-toolbar-characters-page-arabicextended' => 'Arabic extended',
184185 'wikieditor-toolbar-characters-page-persian' => 'Persian',
185186 'wikieditor-toolbar-characters-page-hebrew' => 'Hebrew',
186187 'wikieditor-toolbar-characters-page-bangla' => 'Bangla',

Follow-up revisions

RevisionCommit summaryAuthorDate
r964651.17wmf1: MFT r94135, r95260, r95311, r95601, r95790, r96434catrope18:33, 7 September 2011
r965081.18: MFT r95562, r95570, r95597, r95608, r95647, r95648, r95674, r95790, r95...catrope21:56, 7 September 2011

Status & tagging log