r94472 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94471‎ | r94472 | r94473 >
Date:19:43, 14 August 2011
Author:hashar
Status:ok (Comments)
Tags:
Comment:
MFT to REL1_18:
CSSMin.php r92580 r93822 r94456
Relative protocol revisions r93820 r93258 r93266 r93818 r93819 r93820 r93821 r93820 r93821 r94235 r94422
RN for r93517 (r93518)
RN for r93818 & r94155 (r94425)
Modified paths:
  • /branches/REL1_18/phase3 (modified) (history)
  • /branches/REL1_18/phase3/RELEASE-NOTES-1.18 (modified) (history)
  • /branches/REL1_18/phase3/docs/hooks.txt (modified) (history)
  • /branches/REL1_18/phase3/includes (modified) (history)
  • /branches/REL1_18/phase3/includes/AutoLoader.php (modified) (history)
  • /branches/REL1_18/phase3/includes/CategoryPage.php (modified) (history)
  • /branches/REL1_18/phase3/includes/ChangesList.php (modified) (history)
  • /branches/REL1_18/phase3/includes/ConfEditor.php (modified) (history)
  • /branches/REL1_18/phase3/includes/DefaultSettings.php (modified) (history)
  • /branches/REL1_18/phase3/includes/EditPage.php (modified) (history)
  • /branches/REL1_18/phase3/includes/GlobalFunctions.php (modified) (history)
  • /branches/REL1_18/phase3/includes/HistoryPage.php (modified) (history)
  • /branches/REL1_18/phase3/includes/HttpFunctions.php (modified) (history)
  • /branches/REL1_18/phase3/includes/OutputPage.php (modified) (history)
  • /branches/REL1_18/phase3/includes/Revision.php (modified) (history)
  • /branches/REL1_18/phase3/includes/SpecialPage.php (modified) (history)
  • /branches/REL1_18/phase3/includes/SpecialPageFactory.php (modified) (history)
  • /branches/REL1_18/phase3/includes/Title.php (modified) (history)
  • /branches/REL1_18/phase3/includes/User.php (modified) (history)
  • /branches/REL1_18/phase3/includes/WebRequest.php (modified) (history)
  • /branches/REL1_18/phase3/includes/WikiCategoryPage.php (modified) (history)
  • /branches/REL1_18/phase3/includes/api (modified) (history)
  • /branches/REL1_18/phase3/includes/api/ApiMain.php (modified) (history)
  • /branches/REL1_18/phase3/includes/api/ApiQueryImageInfo.php (modified) (history)
  • /branches/REL1_18/phase3/includes/api/ApiRsd.php (modified) (history)
  • /branches/REL1_18/phase3/includes/api/ApiUpload.php (modified) (history)
  • /branches/REL1_18/phase3/includes/cache/MessageCache.php (modified) (history)
  • /branches/REL1_18/phase3/includes/db/Database.php (modified) (history)
  • /branches/REL1_18/phase3/includes/db/DatabaseError.php (modified) (history)
  • /branches/REL1_18/phase3/includes/db/DatabaseUtility.php (modified) (history)
  • /branches/REL1_18/phase3/includes/db/LoadBalancer.php (modified) (history)
  • /branches/REL1_18/phase3/includes/filerepo/File.php (modified) (history)
  • /branches/REL1_18/phase3/includes/filerepo/ForeignAPIRepo.php (modified) (history)
  • /branches/REL1_18/phase3/includes/filerepo/LocalFile.php (modified) (history)
  • /branches/REL1_18/phase3/includes/installer/DatabaseInstaller.php (modified) (history)
  • /branches/REL1_18/phase3/includes/interwiki/Interwiki.php (modified) (history)
  • /branches/REL1_18/phase3/includes/json/Services_JSON.php (modified) (history)
  • /branches/REL1_18/phase3/includes/libs/CSSMin.php (modified) (history)
  • /branches/REL1_18/phase3/includes/libs/HttpStatus.php (modified) (history)
  • /branches/REL1_18/phase3/includes/media/Exif.php (modified) (history)
  • /branches/REL1_18/phase3/includes/media/ExifBitmap.php (modified) (history)
  • /branches/REL1_18/phase3/includes/parser/CoreParserFunctions.php (modified) (history)
  • /branches/REL1_18/phase3/includes/resourceloader/ResourceLoader.php (modified) (history)
  • /branches/REL1_18/phase3/includes/resourceloader/ResourceLoaderFileModule.php (modified) (history)
  • /branches/REL1_18/phase3/includes/specials (modified) (history)
  • /branches/REL1_18/phase3/includes/specials/SpecialBlock.php (modified) (history)
  • /branches/REL1_18/phase3/includes/specials/SpecialUploadStash.php (modified) (history)
  • /branches/REL1_18/phase3/includes/upload/UploadBase.php (modified) (history)
  • /branches/REL1_18/phase3/includes/upload/UploadFromFile.php (modified) (history)
  • /branches/REL1_18/phase3/includes/upload/UploadStash.php (modified) (history)
  • /branches/REL1_18/phase3/languages (modified) (history)
  • /branches/REL1_18/phase3/languages/messages (modified) (history)
  • /branches/REL1_18/phase3/maintenance/archives (modified) (history)
  • /branches/REL1_18/phase3/maintenance/cleanupTable.inc (modified) (history)
  • /branches/REL1_18/phase3/maintenance/deleteSelfExternals.php (modified) (history)
  • /branches/REL1_18/phase3/maintenance/findHooks.php (modified) (history)
  • /branches/REL1_18/phase3/maintenance/mergeMessageFileList.php (modified) (history)
  • /branches/REL1_18/phase3/maintenance/populateRevisionLength.php (modified) (history)
  • /branches/REL1_18/phase3/maintenance/tables.sql (modified) (history)
  • /branches/REL1_18/phase3/tests/parserTests.php (modified) (history)
  • /branches/REL1_18/phase3/tests/phpunit/Makefile (modified) (history)
  • /branches/REL1_18/phase3/tests/phpunit/includes/GlobalFunctions/wfExpandUrl.php (modified) (history)
  • /branches/REL1_18/phase3/tests/phpunit/includes/api/ApiUploadTest.php (modified) (history)
  • /branches/REL1_18/phase3/tests/phpunit/includes/api/RandomImageGenerator.php (modified) (history)
  • /branches/REL1_18/phase3/tests/phpunit/includes/api/generateRandomImages.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiButtonsAvailabilityTestCase.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiDifferentDatabaseAccountTestCase.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiDifferntDatabasePrefixTestCase.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiErrorsConnectToDatabasePageTestCase.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiErrorsNamepageTestCase.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiHelpFieldHintTestCase.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiInstallationCommonFunction.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiInstallationConfig.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiInstallationMessage.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiInstallationVariables.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiInstallerTestSuite.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiMySQLDataBaseTestCase.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiMySQLiteDataBaseTestCase.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiOnAlreadyInstalledTestCase.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiRestartInstallationTestCase.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiRightFrameworkLinksTestCase.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiUpgradeExistingDatabaseTestCase.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/MediaWikiUserInterfaceTestCase.php (modified) (history)
  • /branches/REL1_18/phase3/tests/selenium/installer/README.txt (modified) (history)
  • /branches/REL1_18/phase3/tests/testHelpers.inc (modified) (history)

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92580Fixes for URL expanding in CSSMin: adjust the offset correctly (this could've...catrope21:19, 19 July 2011
r93258(bug NNNNN) Rewrite most of wfExpandUrl() to handle protocol-relative URLs pr...catrope08:21, 27 July 2011
r93266Rename PROT_* constants to PROTO_*...platonides14:06, 27 July 2011
r93517Adding fix for bug 27427. Fixes unit test. Patch provided by Michael M. throu...krinkle07:39, 30 July 2011
r93518Release-notes for r93517krinkle07:41, 30 July 2011
r93818Introduce $wgVaryOnXFPToAPI which sends Vary: X-Forwarded-Proto (and the appr...catrope12:00, 3 August 2011
r93819Followup r93266: also rename PROT_* to PROTO_* in the commentscatrope12:52, 3 August 2011
r93820Some random URL protocol forcing for protocol-relative URLscatrope12:58, 3 August 2011
r93821Fix r93820: PROT_ -> PROTO_catrope13:11, 3 August 2011
r93822Fix syntax error in r93820catrope13:12, 3 August 2011
r94155(bug 30074) Moving user JS subpages resulted in JS errors because #REDIRECT [...catrope14:23, 10 August 2011
r94235Followup r85025, r85166, r93233: use strict comparison per CR comment, becaus...catrope10:33, 11 August 2011
r94422Add a RELEASE-NOTES note about protocol-relative URLs to the 1.18 RELEASE-NOT...catrope17:35, 13 August 2011
r94425Add RELEASE-NOTES for r93818 and r94155. Adding to the 1.18 file since they'r...catrope18:33, 13 August 2011
r94456Followup to r92580 and r93820: r92580 duplicated the call to wfExpandUrl(), a...catrope13:35, 14 August 2011

Comments

#Comment by Hashar (talk | contribs)   19:47, 14 August 2011

Still need to merge the various extensions change.

Status & tagging log