r94235 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94234‎ | r94235 | r94236 >
Date:10:33, 11 August 2011
Author:catrope
Status:ok
Tags:
Comment:
Followup r85025, r85166, r93233: use strict comparison per CR comment, because "0" != "00" is false
Modified paths:
  • /trunk/phase3/includes/specials/SpecialBlock.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialBlock.php
@@ -555,7 +555,7 @@
556556 # to do this for IPs, but it's pretty unlikely they'd ever get the 'block'
557557 # permission anyway, although the code does allow for it
558558 if( $target === $wgUser->getName() &&
559 - ( $data['PreviousTarget'] != $data['Target'] || !$data['Confirm'] ) )
 559+ ( $data['PreviousTarget'] !== $data['Target'] || !$data['Confirm'] ) )
560560 {
561561 return array( 'ipb-blockingself' );
562562 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r94472MFT to REL1_18:...hashar19:43, 14 August 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85025(bug 23408) give admins a warning before letting them block themselves. Also...happy-melon18:00, 30 March 2011
r85166Follow-up r85025: fix the you're-trying-to-block-yourself-you-twit warning, a...happy-melon23:13, 1 April 2011
r93233* Fix double-escaping from r85025...happy-melon19:04, 26 July 2011

Status & tagging log