r93819 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93818‎ | r93819 | r93820 >
Date:12:52, 3 August 2011
Author:catrope
Status:ok
Tags:
Comment:
Followup r93266: also rename PROT_* to PROTO_* in the comments
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
@@ -437,11 +437,11 @@
438438 * Expand a potentially local URL to a fully-qualified URL. Assumes $wgServer
439439 * is correct.
440440 *
441 - * The meaning of the PROT_* constants is as follows:
442 - * PROT_HTTP: Output a URL starting with http://
443 - * PROT_HTTPS: Output a URL starting with https://
444 - * PROT_RELATIVE: Output a URL starting with // (protocol-relative URL)
445 - * PROT_CURRENT: Output a URL starting with either http:// or https:// , depending on which protocol was used for the current incoming request
 441+ * The meaning of the PROTO_* constants is as follows:
 442+ * PROTO_HTTP: Output a URL starting with http://
 443+ * PROTO_HTTPS: Output a URL starting with https://
 444+ * PROTO_RELATIVE: Output a URL starting with // (protocol-relative URL)
 445+ * PROTO_CURRENT: Output a URL starting with either http:// or https:// , depending on which protocol was used for the current incoming request
446446 *
447447 * @todo this won't work with current-path-relative URLs
448448 * like "subdir/foo.html", etc.

Follow-up revisions

RevisionCommit summaryAuthorDate
r94472MFT to REL1_18:...hashar19:43, 14 August 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93266Rename PROT_* constants to PROTO_*...platonides14:06, 27 July 2011

Status & tagging log