r90741 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90740‎ | r90741 | r90742 >
Date:22:08, 24 June 2011
Author:aaron
Status:ok (Comments)
Tags:
Comment:
Fixed silly test bug
Modified paths:
  • /trunk/extensions/FlaggedRevs/tests/FRUserCountersTest.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/tests/FRUserCountersTest.php
@@ -69,6 +69,7 @@
7070 FRUserCounters::updateUserParams( $copyP, $article, "edit summary" );
7171 $this->assertEquals( $p['totalContentEdits']+1, $copyP['totalContentEdits'],
7272 "Content edit count on content edit" );
 73+
7374 $expected = $p['uniqueContentPages'];
7475 $expected[] = 0;
7576 $this->assertEquals( $expected, $copyP['uniqueContentPages'],
@@ -85,6 +86,9 @@
8687 $copyP = $p;
8788 FRUserCounters::updateUserParams( $copyP, $article, "/* section */" );
8889 $this->assertEquals( $p['editComments'], $copyP['editComments'], "Auto summary" );
 90+
 91+ $title = Title::makeTitleSafe( 4, 'helloworld' );
 92+ $article = new Article( $title );
8993
9094 $copyP = $p;
9195 FRUserCounters::updateUserParams( $copyP, $article, "edit summary" );

Follow-up revisions

RevisionCommit summaryAuthorDate
r92317REL1_18 FR: r87606, r87617, r87669, r87690, r87700, r90388, r90419, r90741, r...reedy21:53, 15 July 2011

Comments

#Comment by 😂 (talk | contribs)   02:44, 30 June 2011

Could you use NS_PROJECT instead of 4?

Status & tagging log