r87669 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87668‎ | r87669 | r87670 >
Date:00:58, 8 May 2011
Author:aaron
Status:ok (Comments)
Tags:
Comment:
Run populate_fr_rev_timestamp() via updater
Modified paths:
  • /trunk/extensions/FlaggedRevs/schema/FlaggedRevsUpdater.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/schema/FlaggedRevsUpdater.hooks.php
@@ -33,8 +33,8 @@
3434 'flaggedrevs_stats', "$base/patch-flaggedrevs_stats.sql", true ) );
3535 $du->addExtensionUpdate( array( 'FlaggedRevsUpdaterHooks::doFlaggedImagesTimestampNULL',
3636 "$base/patch-fi_img_timestamp.sql" ) );
37 - $du->addExtensionUpdate( array( 'addIndex',
38 - 'flaggedrevs', 'page_rev', "$base/patch-fr_page_rev-index.sql", true ) );
 37+ $du->addExtensionUpdate( array( 'FlaggedRevsUpdaterHooks::doFlaggedRevsRevTimestamp',
 38+ "$base/patch-fr_page_rev-index.sql" ) );
3939 } elseif ( $wgDBtype == 'postgres' ) {
4040 $base = dirname( __FILE__ ) . '/postgres';
4141 // Initial install tables (current schema)
@@ -62,8 +62,8 @@
6363 // @TODO: PG stats table???
6464 $du->addExtensionUpdate( array( 'FlaggedRevsUpdaterHooks::doFlaggedImagesTimestampNULL',
6565 "$base/patch-fi_img_timestamp.sql" ) );
66 - $du->addExtensionUpdate( array( 'addIndex',
67 - 'flaggedrevs', 'page_rev', "$base/patch-fr_page_rev-index.sql", true ) );
 66+ $du->addExtensionUpdate( array( 'FlaggedRevsUpdaterHooks::doFlaggedRevsRevTimestamp',
 67+ "$base/patch-fr_page_rev-index.sql" ) );
6868 } elseif ( $wgDBtype == 'sqlite' ) {
6969 $base = dirname( __FILE__ ) . '/mysql';
7070 $du->addExtensionUpdate( array( 'addTable',
@@ -82,4 +82,21 @@
8383 $du->getDB()->sourceFile( $patch );
8484 $du->output( "done.\n" );
8585 }
 86+
 87+ public static function doFlaggedRevsRevTimestamp( $du, $patch ) {
 88+ $exists = $du->getDB()->fieldInfo( 'flaggedrevs', 'fr_rev_timestamp' );
 89+ if ( $exists ) {
 90+ $du->output( "...fr_rev_timestamp already exists.\n" );
 91+ return;
 92+ }
 93+ include_once( dirname( __FILE__ ) . "/../maintenance/populateRevTimestamp.inc" );
 94+ if ( !function_exists( 'populate_fr_rev_timestamp' ) ) {
 95+ $du->output( "...populateRevTimestamp.inc missing! Aborting fr_rev_timestamp update.\n" );
 96+ return; // sanity
 97+ }
 98+ $du->output( "Adding fr_rev_timestamp and redoing flaggedrevs table indexes... " );
 99+ $du->getDB()->sourceFile( $patch );
 100+ populate_fr_rev_timestamp( 0 );
 101+ $du->output( "done.\n" );
 102+ }
86103 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r92317REL1_18 FR: r87606, r87617, r87669, r87690, r87700, r90388, r90419, r90741, r...reedy21:53, 15 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86179Overdue changes to `flaggedrevs` table:...aaron03:39, 16 April 2011

Comments

#Comment by Aaron Schulz (talk | contribs)   00:59, 8 May 2011

Note: I don't really like how populate_fr_rev_timestamp() uses echo().

Status & tagging log