r87690 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r87689‎ | r87690 | r87691 >
Date:18:49, 8 May 2011
Author:aaron
Status:ok
Tags:
Comment:
Added missing $dbw->timestamp() format call for new fr_rev_timestamp field
Modified paths:
  • /trunk/extensions/FlaggedRevs/dataclasses/FlaggedRevision.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/dataclasses/FlaggedRevision.php
@@ -297,7 +297,7 @@
298298 $revRow = array(
299299 'fr_page_id' => $this->getPage(),
300300 'fr_rev_id' => $this->getRevId(),
301 - 'fr_rev_timestamp' => $this->getRevTimestamp(),
 301+ 'fr_rev_timestamp' => $dbw->timestamp( $this->getRevTimestamp() ),
302302 'fr_user' => $this->mUser,
303303 'fr_timestamp' => $dbw->timestamp( $this->mTimestamp ),
304304 'fr_quality' => $this->mQuality,
@@ -336,8 +336,7 @@
337337 $dbw = wfGetDB( DB_MASTER );
338338 # Delete from flaggedrevs table
339339 $dbw->delete( 'flaggedrevs',
340 - array( 'fr_rev_id' => $this->getRevId() ),
341 - __METHOD__ );
 340+ array( 'fr_rev_id' => $this->getRevId() ), __METHOD__ );
342341 # Wipe versioning params...
343342 $dbw->delete( 'flaggedtemplates',
344343 array( 'ft_rev_id' => $this->getRevId() ), __METHOD__ );

Follow-up revisions

RevisionCommit summaryAuthorDate
r92317REL1_18 FR: r87606, r87617, r87669, r87690, r87700, r90388, r90419, r90741, r...reedy21:53, 15 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86179Overdue changes to `flaggedrevs` table:...aaron03:39, 16 April 2011

Status & tagging log