r90388 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90387‎ | r90388 | r90389 >
Date:08:50, 19 June 2011
Author:aaron
Status:ok
Tags:
Comment:
Fixed injectPostEditURLParams() query generation (& is already there)
Modified paths:
  • /trunk/extensions/FlaggedRevs/presentation/FlaggedPageView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/presentation/FlaggedPageView.php
@@ -1674,12 +1674,15 @@
16751675 array( ':' , '.' ), array( '%3A', '%' ), // hack: reverse encoding
16761676 substr( $sectionAnchor, 1 ) // remove the '#'
16771677 );
1678 - $params += array('fromsection' => $section );
 1678+ $params += array( 'fromsection' => $section );
16791679 $sectionAnchor = ''; // go to the top of the page to see notice
16801680 }
16811681 }
16821682 }
1683 - $extraQuery = wfAppendQuery( $extraQuery, $params );
 1683+ if ( $extraQuery !== '' ) {
 1684+ $extraQuery .= '&';
 1685+ }
 1686+ $extraQuery .= wfArrayToCGI( $params ); // note: EditPage will add initial "&"
16841687 return true;
16851688 }
16861689

Follow-up revisions

RevisionCommit summaryAuthorDate
r92317REL1_18 FR: r87606, r87617, r87669, r87690, r87700, r90388, r90419, r90741, r...reedy21:53, 15 July 2011

Status & tagging log