r90341 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90340‎ | r90341 | r90342 >
Date:15:06, 18 June 2011
Author:btongminh
Status:ok (Comments)
Tags:
Comment:
MFT non test part of r90340
(bug 29408) Key 'something.' is not in a proper format
Modified paths:
  • /branches/REL1_17/phase3/includes/upload/UploadStash.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/includes/upload/UploadStash.php
@@ -14,7 +14,7 @@
1515 class UploadStash {
1616
1717 // Format of the key for files -- has to be suitable as a filename itself (e.g. ab12cd34ef.jpg)
18 - const KEY_FORMAT_REGEX = '/^[\w-]+\.\w+$/';
 18+ const KEY_FORMAT_REGEX = '/^[\w-]+\.\w*$/';
1919
2020 // repository that this uses to store temp files
2121 // public because we sometimes need to get a LocalFile within the same repo.

Follow-up revisions

RevisionCommit summaryAuthorDate
r90531Follow up with the problem noted in r90530....platonides15:13, 21 June 2011
r90569Updates for 1.17.0, release notes fixes for r90341 and r90492.tstarling03:56, 22 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90340(bug 29408) Key 'something.' is not in a proper format...btongminh14:56, 18 June 2011

Comments

#Comment by Tim Starling (talk | contribs)   03:37, 22 June 2011

Please add release notes when you backport something to a release branch.

Status & tagging log