r70715 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70714‎ | r70715 | r70716 >
Date:16:45, 8 August 2010
Author:ashley
Status:reverted
Tags:
Comment:
follow-up to r70703: converted spaces to tabs and trimmed trailing spaces
Modified paths:
  • /trunk/phase3/includes/api/ApiEditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiEditPage.php
@@ -57,16 +57,14 @@
5858 if ( !$titleObj || $titleObj->isExternal() ) {
5959 $this->dieUsageMsg( array( 'invalidtitle', $params['title'] ) );
6060 }
61 -
 61+
6262 if( $params['redirect'] && $titleObj->isRedirect() ) {
63 -
6463 $pageSet = new ApiPageSet( $this->getQuery(), true ); // Or true, true to also do variant conversion of titles
6564 $pageSet->populateFromTitles( array( $titleObj ) );
6665 foreach ( $pageSet->getRedirectTitles() as $from => $to ) {
67 - $redirsValues[] = array( 'from' => $from, 'to' => $to );
 66+ $redirsValues[] = array( 'from' => $from, 'to' => $to );
6867 }
6968
70 -
7169 $this->getResult()->setIndexedTagName( $redirValues, 'r' );
7270 $this->getResult()->addValue( null, 'redirects', $redirValues );
7371 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r75280Revert r70703 and followup r70715: broke &redirect for API edit with a fatal ...catrope17:48, 23 October 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70703Followup to r70658: Code styling, use ApiPageSet to fix redirects.soxred9315:03, 8 August 2010

Status & tagging log