r89348 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89347‎ | r89348 | r89349 >
Date:16:13, 2 June 2011
Author:catrope
Status:ok
Tags:
Comment:
Revert r88722 (allow multiple values for letype): this won't play nice with query indexing
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryLogEvents.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -93,7 +93,6 @@
9494 title inputs
9595 * (bug 20699) API watchlist should list log-events
9696 * (bug 29070) Add token to action=watch
97 -* (bug 29120) ApiQueryLogEvents: let letype accept multiple values
9897 * (bug 29221) Expose oldrevid in watchlist output
9998
10099 === Languages updated in 1.19 ===
Index: trunk/phase3/includes/api/ApiQueryLogEvents.php
@@ -111,7 +111,8 @@
112112 list( $type, $action ) = explode( '/', $params['action'] );
113113 $this->addWhereFld( 'log_type', $type );
114114 $this->addWhereFld( 'log_action', $action );
115 - } else if ( !is_null( $params['type'] ) ) {
 115+ }
 116+ else if ( !is_null( $params['type'] ) ) {
116117 $this->addWhereFld( 'log_type', $params['type'] );
117118 $index['logging'] = 'type_time';
118119 }
@@ -370,8 +371,7 @@
371372 )
372373 ),
373374 'type' => array(
374 - ApiBase::PARAM_TYPE => $wgLogTypes,
375 - ApiBase::PARAM_ISMULTI => true,
 375+ ApiBase::PARAM_TYPE => $wgLogTypes
376376 ),
377377 'action' => array(
378378 ApiBase::PARAM_TYPE => array_keys( $wgLogActions )

Follow-up revisions

RevisionCommit summaryAuthorDate
r89354Followup r89348...reedy18:39, 2 June 2011
r95067Revert r95058 (make letype multivalue): has been applied before in r88722 and...catrope07:19, 20 August 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88722* (bug 29120) ApiQueryLogEvents: let letype accept multiple values...reedy16:04, 24 May 2011

Status & tagging log