r89349 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r89348‎ | r89349 | r89350 >
Date:16:38, 2 June 2011
Author:mah
Status:ok (Comments)
Tags:
Comment:
follow up r88502 with a fix to resource loader to restore tochidden
removal addition.
Modified paths:
  • /trunk/phase3/resources/mediawiki.util/mediawiki.util.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki.util/mediawiki.util.js
——@@ -201,6 +201,7 @@
202202 if ( $tocList.is( ':hidden' ) ) {
203203 $tocList.slideDown( 'fast', callback );
204204 $toggleLink.text( mw.msg( 'hidetoc' ) );
 205+ $( '#toc' ).removeClass( 'tochidden' );
205206 $.cookie( 'mw_hidetoc', null, {
206207 expires: 30,
207208 path: '/'
——@@ -209,6 +210,7 @@
210211 } else {
211212 $tocList.slideUp( 'fast', callback );
212213 $toggleLink.text( mw.msg( 'showtoc' ) );
 214+ $( '#toc' ).addClass( 'tochidden' );
213215 $.cookie( 'mw_hidetoc', '1', {
214216 expires: 30,
215217 path: '/'

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78941Porting tocToggle to ResourceLoader...krinkle00:55, 24 December 2010

Comments

#Comment by Brion VIBBER (talk | contribs)   21:07, 2 June 2011

a) this doesn't seem to be resource-loader specific?

b) restore tochidden removal addition? uhhh :)

#Comment by Catrope (talk | contribs)   21:09, 2 June 2011

Followup rev number is wrong, Mark meant r78941.

I changed the TOC code because ResourceLoader had broken it, and in the course of that ditched tochidden. That broke other things, so Mark re-introduced tochidden in this commit.

#Comment by Brion VIBBER (talk | contribs)   21:57, 2 June 2011

Now it all makes sense. :D Confirmed it seems to work as expected!

Status & tagging log