r89347 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89346‎ | r89347 | r89348 >
Date:16:10, 2 June 2011
Author:platonides
Status:reverted (Comments)
Tags:
Comment:
Fix for r89263: this to $this
Modified paths:
  • /trunk/phase3/includes/installer/DatabaseUpdater.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/DatabaseUpdater.php
@@ -251,7 +251,7 @@
252252 $this->runUpdates( $this->getOldGlobalUpdates(), false );
253253 $this->runUpdates( $this->getExtensionUpdates(), true );
254254 foreach ( $this->getExtensionUpdaters() as $updaterClass ) {
255 - $eupdater = new $updaterClass(this);
 255+ $eupdater = new $updaterClass( $this );
256256 $eupdater->doUpdates();
257257 }
258258 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r89586Revert r89263, r89297, r89347: unclear whether this is needed; DatabaseUpdate...brion18:35, 6 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89263* suggestion for ExtensionUpdater that would handle DB install/update of exte...freakolowsky15:15, 1 June 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   18:36, 6 June 2011

Reverted for now in r89586 along with parent r89263.

Status & tagging log